<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111917/">http://git.reviewboard.kde.org/r/111917/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 7th, 2013, 6:56 a.m. UTC, <b>Kevin Krammer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/111917/diff/1/?file=176439#file176439line2199" style="color: black; font-weight: bold; text-decoration: underline;">kmail/editor/kmcomposewin.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool KMComposeWin::insertFromMimeData( const QMimeData *source, bool forceAttachment )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">2199</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">const</span> <span class="n">QAction</span> <span class="o">*</span><span class="n">addAsTextAction</span> <span class="o">=</span> <span class="n">p</span><span class="p">.</span><span class="n">addAction</span><span class="p">(</span> <span class="n">i18np</span><span class="p">(</span><span class="s">"Add URL into Message &Text"</span><span class="p">,</span> <span class="s">"Add URLs into Message &Text"</span><span class="p">,</span> <span class="n">urlList</span><span class="p">.</span><span class="n">size</span><span class="p">()</span> <span class="p">)</span> <span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">2199</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">const</span> <span class="n">QAction</span> <span class="o">*</span><span class="n">addAsTextAction</span> <span class="o">=</span> <span class="n">p</span><span class="p">.</span><span class="n">addAction</span><span class="p">(</span> <span class="n">i18np</span><span class="p">(</span><span class="s">"Add URL into Message <span class="hl">as </span>&Text"</span><span class="p">,</span> <span class="s">"Add URLs into Message <span class="hl">as </span>&Text"</span><span class="p">,</span> <span class="n">urlList</span><span class="p">.</span><span class="n">size</span><span class="p">()</span> <span class="p">)</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">My suggestion would be
"Add URL as Message Text"
"Add URLs as Message Text"</pre>
</blockquote>
<p>On August 7th, 2013, 8:18 a.m. UTC, <b>Ovidiu-Florin Bogdan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I believe that if you say "as Text" it is clearer that it will be text and not a link.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">indeed, hence my suggestion using exactly that</pre>
<br />
<p>- Kevin</p>
<br />
<p>On August 7th, 2013, 8:20 a.m. UTC, Ovidiu-Florin Bogdan wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Documentation and KDEPIM.</div>
<div>By Ovidiu-Florin Bogdan.</div>
<p style="color: grey;"><i>Updated Aug. 7, 2013, 8:20 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This function name is confusing as it leads the user to believe that the URL being pasted in the message is pasted as a URL, so I've renamed it to "Add URL into Message as Text"</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=323246">323246</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kmail/editor/kmcomposewin.cpp <span style="color: grey">(eee96e5)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111917/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>