<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109401/">http://git.reviewboard.kde.org/r/109401/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 11th, 2013, 4:06 a.m. UTC, <b>T.C. Hollingsworth</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">LGTM for the most part.
I really don't think we should be using &kappname; at all in Fundamentals TBH. I think using &kde-sc; explicitly is less confusing. But this is my fault, so I can fix it later. ;-)</pre>
</blockquote>
<p>On March 11th, 2013, 11:36 p.m. UTC, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tried to apply only the minimum number of changes, following the style used in other places. I have to say that I had to look at the source docbook to understand the meaning of &kappname; in this context, so I agree that it can be replaced. My proposal is: I will apply the revised patch, and then I would replace all the occurencies of &kappname; with &kde-sc; in one single commit, in order to separate a "meaningful" commit from a simple search-and-replace. Would it be acceptable?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yeah, it's definitely out of scope for this patch which is why I said I'd fix it later. :-) Feel free to go ahead and do it yourself though.</pre>
<br />
<p>- T.C.</p>
<br />
<p>On March 11th, 2013, 11:36 p.m. UTC, Luigi Toscano wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Documentation.</div>
<div>By Luigi Toscano.</div>
<p style="color: grey;"><i>Updated March 11, 2013, 11:36 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">&kappname; (which here is the same entity as "&kde-sc;") has been used sometimes instead of &kde; because it refers to the SC (install.docbook).
A name has been added to &kde; (like "&kde; applications/software") as the content is general for any KDE applications, and for sure it is not about the KDE project. To be honest, when cmake is mentioned, even "&kde; software" is a bit restrictive, as for example Oxygen icons use cmake too, but I would say it is more a details for developers in this document.
Similarly, &kappname; has been replaced with &kde; when it was close to such names ("applications"), as the content is valid for any KDE Platform-based application.
A bit different change when the content of About KDE is described, as it clearly state the version of KDE Development Platform in addition to the program version, and not a generic KDE version.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>doc/fundamentals/ui.docbook <span style="color: grey">(eb962df)</span></li>
<li>doc/fundamentals/tasks.docbook <span style="color: grey">(71c6288)</span></li>
<li>doc/fundamentals/config.docbook <span style="color: grey">(e750dfe)</span></li>
<li>doc/fundamentals/install.docbook <span style="color: grey">(71db09c)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109401/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>