<!DOCTYPE html><html><head><title></title><style type="text/css">p.MsoNormal,p.MsoNoSpacing{margin:0}</style></head><body><div>I'm a bit confused as to why this was only added to the release/23.08 branch<br></div><div>and not master as well.<br></div><div><br></div><div>Also the licensing issue was not solved correctly, see the following patch:<br></div><div><a href="https://invent.kde.org/accessibility/kontrast/-/commit/17ece874e0f2fda3f8a6553ac7386b911faad405">https://invent.kde.org/accessibility/kontrast/-/commit/17ece874e0f2fda3f8a6553ac7386b911faad405</a><br></div><div><br></div><div>In the future, please open a merge request. This is the sort of issues that can<br></div><div>be easily caught up in code reviews ;)<br></div><div><br></div><div>Cheers,<br></div><div>Carl<br></div><div><br></div><div>On Tue, Oct 17, 2023, at 11:07 PM, Scarlett Moore wrote:<br></div><blockquote type="cite" id="qt" style=""><div>Fixed!<br></div><div>Scarlett<br></div><div><br></div><div>On Tue, Oct 17, 2023 at 1:54 PM Albert Astals Cid <<a href="mailto:aacid@kde.org">aacid@kde.org</a>> wrote:<br></div><div>><br></div><div>> Please work on fixing them, otherwise i will remove the failing CI<br></div><div>> jobs on their 4th failing week, it is very important that CI is passing for<br></div><div>> multiple reasons.<br></div><div>><br></div><div>> Good news: We're down to only 1 non passing repository.<br></div><div>><br></div><div>> = FAILING UNIT TESTS =<br></div><div>><br></div><div>> kontrast: (1st week)<br></div><div>> * <a href="https://invent.kde.org/accessibility/kontrast/-/pipelines/501951">https://invent.kde.org/accessibility/kontrast/-/pipelines/501951</a><br></div><div>> * reuse check is failing<br></div><div>><br></div><div>><br></div><div><br></div></blockquote><div><br></div></body></html>