<div dir="ltr"><div dir="ltr">On Thu, Aug 24, 2023 at 5:00 AM Albert Astals Cid <<a href="mailto:aacid@kde.org">aacid@kde.org</a>> wrote:<br></div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">El dimecres, 23 d’agost de 2023, a les 18:29:10 (CEST), Scarlett Moore va escriure:<br>
> After some testing and various complicated options, the easiest I have<br>
> found is importing our github mirror in launchpad ( this avoids the<br>
> polling on kde servers ) and we can create our necessary snap recipes<br>
> and KDE infrastructure is unaffected save the already in place github<br>
> mirror. Launchpad does everything else ( building and uploading to<br>
> store ) I see no reason not to move forward as KDE infrastructure will<br>
> have much less involvement in the snap lifecycle aside from the<br>
> snapcraft files being in the application repository. As mentioned<br>
> before this will allow developers closer involvement with snap<br>
> developers.<br>
<br>
Honestly I'm still a bit lost on what is you are trying to do regarding Snap and the KDE repos :D<br></blockquote><div><br></div><div>I have to admit I am similarly confused. </div><div><br></div><div>I thought this was originally about CI, which is why I proposed tying this in through .gitlab-ci.yml.</div><div>Using that mechanism if this is really about final release builds doesn't make much sense.</div><div><br></div><div>Having a look at what was committed to Blinken's repository though, i'm not sure there is much that would stop this being actual CI (assuming someone got it working within Docker)?</div><div><br></div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
Are we going for CI or CD?<br>
<br>
CI -> snap is compiled on each commit and MR to make sure we don't break the snap build<br>
<br>
CD -> We have an almost-automated way of doing snap "release" builds.<br>
<br>
<br>
To give some examples:<br>
<br>
This is arianna's KDE flatpak CI<br>
<a href="https://invent.kde.org/graphics/arianna/-/jobs/1142328" rel="noreferrer" target="_blank">https://invent.kde.org/graphics/arianna/-/jobs/1142328</a><br>
It builds arianna using flatpak with each commit but the artifacts are "unused"<br>
<br>
<br>
This is Okular's KDE Windows CI<br>
<a href="https://invent.kde.org/graphics/okular/-/jobs/1142178" rel="noreferrer" target="_blank">https://invent.kde.org/graphics/okular/-/jobs/1142178</a><br>
It builds each commit to make sure the Windows build doesn't get broken<br>
<br>
<br>
This is Okular's KDE Windows CD<br>
<a href="https://binary-factory.kde.org/job/Okular_Release_win64/" rel="noreferrer" target="_blank">https://binary-factory.kde.org/job/Okular_Release_win64/</a><br>
It builds release Okular nightly in a way that is a release build and can be easily uploaded to the Windows Store<br>
<br>
<br>
This is Okular flathub CD<br>
<a href="https://github.com/flathub/org.kde.okular" rel="noreferrer" target="_blank">https://github.com/flathub/org.kde.okular</a><br>
<a href="https://buildbot.flathub.org/#/apps/org.kde.okular" rel="noreferrer" target="_blank">https://buildbot.flathub.org/#/apps/org.kde.okular</a><br>
It is a convenient way to generate new builds each time a stable release happens<br>
<br>
<br>
I see you committed this<br>
<a href="https://invent.kde.org/education/blinken/-/blob/master/.snapcraft.yaml" rel="noreferrer" target="_blank">https://invent.kde.org/education/blinken/-/blob/master/.snapcraft.yaml</a><br>
<br>
<br>
What is that going to give us?<br>
<br>
<br>
Cheers,<br>
Albert<br></blockquote><div><br></div><div>Cheers,</div><div>Ben</div><div> </div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left:1px solid rgb(204,204,204);padding-left:1ex">
<br>
<br>
> Thanks,<br>
> Scarlett<br>
> <br>
> On Sun, Aug 20, 2023 at 7:20 PM Justin Zobel <<a href="mailto:justin.zobel@gmail.com" target="_blank">justin.zobel@gmail.com</a>> wrote:<br>
> > I think there is a lot of misunderstanding here.<br>
> > <br>
> > In GitLab CI only test builds are done and artifacts are kept so people<br>
> > can test an AppImage or Flatpak without having to compile locally.<br>
> > <br>
> > Stable releases are done by the Release Team via scripts to tarballs.<br>
> > Flatpaks are done via Flathub and are done (usually) automatically via<br>
> > the Flatpak External Data Checker.<br>
> > <br>
> > Hopefully this clarifies the situation.<br>
> > <br>
> > On 21/8/23 08:48, Scarlett Moore wrote:<br>
> > > On Sun, Aug 20, 2023, 4:14 PM Julius Künzel<br>
> > > <br>
> > > <<a href="mailto:jk.kdedev@smartlab.uber.space" target="_blank">jk.kdedev@smartlab.uber.space</a>> wrote:<br>
> > > To me it seems this discussion is quite abstract and there are<br>
> > > several misunderstandings because not everybody knows every detail<br>
> > > of snap packaging and/or the KDE infrastructure (me neither).<br>
> > > <br>
> > > I understand that from an organizational perspective most people<br>
> > > like the idea of having the files in the repos, but have technical<br>
> > > doubts. Hence, I wonder whether it would be a good idea to take<br>
> > > one KDE app to try and showcase this suggestion?<br>
> > > <br>
> > > Cheers,<br>
> > > Julius<br>
> > > <br>
> > > Sounds like a great idea to me.<br>
> > > Scarlett<br>
> > > <br>
> > > 20.08.2023 17:55:24 Laura David Hurka <<a href="mailto:david.hurka@mailbox.org" target="_blank">david.hurka@mailbox.org</a>>:<br>
> > > > On Sunday, August 20, 2023 12:47:10 PM CEST Ben Cooksley wrote:<br>
> > > >> On Sun, Aug 20, 2023 at 12:43 PM Scarlett Moore <<br>
> > > >> <br>
> > > >> <a href="mailto:scarlett.gately.moore@gmail.com" target="_blank">scarlett.gately.moore@gmail.com</a>> wrote:<br>
> > > >>> Only on release! We will not be building from master! We don't<br>
> > > <br>
> > > want<br>
> > > <br>
> > > >>> unstable snaps.<br>
> > > >>> Thanks,<br>
> > > >>> Scarlett<br>
> > > >> <br>
> > > >> In that particular case the jobs should be manually triggered<br>
> > > >> only.<br>
> > > >> <br>
> > > >> Gitlab CI is really made for building artifacts for a given<br>
> > > <br>
> > > commit rather<br>
> > > <br>
> > > >> than for a specified version though, so this is definitely<br>
> > > <br>
> > > going to be a<br>
> > > <br>
> > > >> case of things not fitting quite right.<br>
> > > >> <br>
> > > >> Cheers,<br>
> > > >> Ben<br>
> > > >> [...]<br>
> > > > <br>
> > > > This confuses me too.<br>
> > > > It seems Scarlett wants to use a “deploy” stage [1] and a job<br>
> > > <br>
> > > rule [2]<br>
> > > <br>
> > > > to run snap build&release jobs automatically when the release is<br>
> > > <br>
> > > done.<br>
> > > <br>
> > > > If you mean that Gitlab CI should not be used to automate<br>
> > > <br>
> > > release jobs,<br>
> > > <br>
> > > > you should elaborate more how binary-factory is meant to be<br>
> > > <br>
> > > replaced.<br>
> > > <br>
> > > > Otherwise, do you just note that Gitlab CI is suboptimal,<br>
> > > > or do you recommend to use something else?<br>
> > > > Like: “Release build: automatic is fine. Release publish: please<br>
> > > <br>
> > > only manual”?<br>
> > > <br>
> > > > Cheers, David<br>
> > > > <br>
> > > > <br>
> > > > [1] <a href="https://docs.gitlab.com/ee/ci/yaml/#stages" rel="noreferrer" target="_blank">https://docs.gitlab.com/ee/ci/yaml/#stages</a><br>
> > > > [2] like this:<br>
> > > > <br>
> > > > snap-release-job:<br>
> > > > rules:<br>
> > > > -if: $CI_COMMIT_TAG =~ /^v[0-9][0-9]\.[0-9][0-9]\.[0-9][0-9]$/<br>
> > > > <br>
> > > > [...]<br>
> > > > <br>
> > > > see also:<br>
> > > <a href="https://docs.gitlab.com/ee/ci/jobs/job_control.html#use-predefined-c" rel="noreferrer" target="_blank">https://docs.gitlab.com/ee/ci/jobs/job_control.html#use-predefined-c</a><br>
> > > icd-variables-to-run-jobs-only-in-specific-pipeline-types<br>
<br>
<br>
<br>
<br>
</blockquote></div></div>