<div dir="ltr"><div>This week I got most confused by files moving around again in our packages.  It turns out several apps have checks on ECM version for new KDEInstallDirs that were added around ECM 5.57.  If the app uses <br></div><div><br></div><div><span id="gmail-LC22" class="gmail-line" lang="cmake">  <span class="gmail-nb">if</span><span class="gmail-p">(</span><span class="gmail-si">${</span><span class="gmail-nv">ECM_VERSION</span><span class="gmail-si">}</span> <span class="gmail-idiff gmail-left gmail-right gmail-deletion">STR</span>GREATER <span class="gmail-s2">"5.57.0"</span><span class="gmail-p">)</span></span></div><div><span id="gmail-LC22" class="gmail-line" lang="cmake"><span class="gmail-p"><br></span></span></div><div><span id="gmail-LC22" class="gmail-line" lang="cmake"><span class="gmail-p">It will break with KF5 5.100 <br></span></span></div><div><span id="gmail-LC22" class="gmail-line" lang="cmake"><span class="gmail-p"><br></span></span></div><div><span id="gmail-LC22" class="gmail-line" lang="cmake"><span class="gmail-p">Instead it should use <br></span></span></div><div><span id="gmail-LC22" class="gmail-line" lang="cmake"><span class="gmail-p"><span id="gmail-LC22" class="gmail-line" lang="cmake"><br></span></span></span></div><div><span id="gmail-LC22" class="gmail-line" lang="cmake"><span class="gmail-p"><span id="gmail-LC22" class="gmail-line" lang="cmake">  <span class="gmail-nb">if</span><span class="gmail-p">(</span><span class="gmail-si">${</span><span class="gmail-nv">ECM_VERSION</span><span class="gmail-si">}</span> <span class="gmail-idiff gmail-left gmail-right gmail-addition">VERSION_</span>GREATER <span class="gmail-s2">"5.57.0"</span><span class="gmail-p">)</span></span></span></span></div><div><span id="gmail-LC22" class="gmail-line" lang="cmake"><span class="gmail-p"><span id="gmail-LC22" class="gmail-line" lang="cmake"><span class="gmail-p"><br></span></span></span></span></div><div><span id="gmail-LC22" class="gmail-line" lang="cmake"><span class="gmail-p"><span id="gmail-LC22" class="gmail-line" lang="cmake"><span class="gmail-p">Or just depend on a newer ECM version, a few apps we've found had these broken version checks but depended on a newer ECM version anyway so the test can be removed.</span></span></span></span></div><div><span id="gmail-LC22" class="gmail-line" lang="cmake"><span class="gmail-p"><span id="gmail-LC22" class="gmail-line" lang="cmake"><span class="gmail-p"><br></span></span></span></span></div><div><span id="gmail-LC22" class="gmail-line" lang="cmake"><span class="gmail-p"><span id="gmail-LC22" class="gmail-line" lang="cmake"><span class="gmail-p">Examples:</span></span></span></span></div><div><span id="gmail-LC22" class="gmail-line" lang="cmake"><span class="gmail-p"><span id="gmail-LC22" class="gmail-line" lang="cmake"><span class="gmail-p"><a href="https://invent.kde.org/office/tellico/-/merge_requests/6/diffs">https://invent.kde.org/office/tellico/-/merge_requests/6/diffs</a></span></span></span></span></div><div><span id="gmail-LC22" class="gmail-line" lang="cmake"><span class="gmail-p"><span id="gmail-LC22" class="gmail-line" lang="cmake"><span class="gmail-p"><a href="https://invent.kde.org/graphics/okular/-/merge_requests/666/diffs">https://invent.kde.org/graphics/okular/-/merge_requests/666/diffs</a></span></span></span></span></div><div><span id="gmail-LC22" class="gmail-line" lang="cmake"><span class="gmail-p"><span id="gmail-LC22" class="gmail-line" lang="cmake"><span class="gmail-p"><br></span></span></span></span></div><div><span id="gmail-LC22" class="gmail-line" lang="cmake"><span class="gmail-p"><span id="gmail-LC22" class="gmail-line" lang="cmake"><span class="gmail-p">Jonathan</span></span></span></span></div><div><span id="gmail-LC22" class="gmail-line" lang="cmake"><span class="gmail-p"><span id="gmail-LC22" class="gmail-line" lang="cmake"><span class="gmail-p"><br></span></span></span></span></div></div>