<div dir="auto"><div>I am having some strange issues with clazy's <span style="font-family:sans-serif">connect-non-signal and incorrect-emit</span> checks. The only additional insight I can provide beyond what I knew when I made this commit is that compiling kdiff3 in release or release with debug info configuration resolves the warnings.</div><div dir="auto"><font face="sans-serif"><br></font><div class="gmail_quote" dir="auto"><div dir="ltr" class="gmail_attr">---------- Forwarded message ---------<br>From: <strong class="gmail_sendername" dir="auto">Michael Reeves</strong> <span dir="auto"><<a href="mailto:null@kde.org">null@kde.org</a>></span><br>Date: Fri, Dec 18, 2020, 5:02 PM<br>Subject: [sdk/kdiff3] src: Disable problematic clazy warnings<br>To: <<a href="mailto:kde-commits@kde.org">kde-commits@kde.org</a>><br></div><br><br>Git commit 4b319434a0a0e9c11f3de358bb307dca75750fb7 by Michael Reeves.<br>
Committed on 18/12/2020 at 21:58.<br>
Pushed by mreeves into branch 'master'.<br>
<br>
Disable problematic clazy warnings<br>
<br>
connect-non-signal and incorrect-emit are generating over one hundred warnings.<br>
After performing a quick triage of both clazy and kdiff3 regarding these warnings.<br>
I have determined there is no obvious fix and they are false positives.<br>
This issue apears with clang/llvm 11 and clazy 1.8.<br>
I don't have time to track this down further. Deactiving the offenders<br>
until this is resolved.<br>
<br>
M +2 -0 src/MergeFileInfos.cpp<br>
M +1 -0 src/defmac.h<br>
M +1 -0 src/difftextwindow.cpp<br>
M +1 -0 src/difftextwindow.h<br>
M +2 -0 src/directorymergewindow.cpp<br>
M +1 -0 src/kdiff3.cpp<br>
M +1 -1 src/kdiff3.h<br>
M +1 -0 src/kdiff3_shell.cpp<br>
M +1 -0 src/mergeresultwindow.cpp<br>
M +1 -0 src/pdiff.cpp<br>
M +1 -0 src/smalldialogs.cpp<br>
<br>
<a href="https://invent.kde.org/sdk/kdiff3/commit/4b319434a0a0e9c11f3de358bb307dca75750fb7" rel="noreferrer noreferrer" target="_blank">https://invent.kde.org/sdk/kdiff3/commit/4b319434a0a0e9c11f3de358bb307dca75750fb7</a><br>
<br>
diff --git a/src/MergeFileInfos.cpp b/src/MergeFileInfos.cpp<br>
index a009fa4..3d0ba16 100644<br>
--- a/src/MergeFileInfos.cpp<br>
+++ b/src/MergeFileInfos.cpp<br>
@@ -5,6 +5,8 @@<br>
* SPDX-FileCopyrightText: 2018-2020 Michael Reeves <a href="mailto:reeves.87@gmail.com" target="_blank" rel="noreferrer">reeves.87@gmail.com</a><br>
* SPDX-License-Identifier: GPL-2.0-or-later<br>
*/<br>
+//clazy:excludeall=connect-non-signal,incorrect-emit<br>
+<br>
#include "MergeFileInfos.h"<br>
<br>
#include "DirectoryInfo.h"<br>
diff --git a/src/defmac.h b/src/defmac.h<br>
index 6ac4d53..76c03aa 100644<br>
--- a/src/defmac.h<br>
+++ b/src/defmac.h<br>
@@ -8,6 +8,7 @@<br>
This header is defined macros of general purpose.<br>
<br>
*****************************************************************************/<br>
+//clazy:excludeall=connect-non-signal,incorrect-emit<br>
<br>
#ifndef DEFMAC_H<br>
#define DEFMAC_H<br>
diff --git a/src/difftextwindow.cpp b/src/difftextwindow.cpp<br>
index 848cb64..5f18005 100644<br>
--- a/src/difftextwindow.cpp<br>
+++ b/src/difftextwindow.cpp<br>
@@ -5,6 +5,7 @@<br>
* SPDX-FileCopyrightText: 2018-2020 Michael Reeves <a href="mailto:reeves.87@gmail.com" target="_blank" rel="noreferrer">reeves.87@gmail.com</a><br>
* SPDX-License-Identifier: GPL-2.0-or-later<br>
*/<br>
+//clazy:excludeall=connect-non-signal,incorrect-emit<br>
<br>
#include "difftextwindow.h"<br>
<br>
diff --git a/src/difftextwindow.h b/src/difftextwindow.h<br>
index 64bf715..aa89866 100644<br>
--- a/src/difftextwindow.h<br>
+++ b/src/difftextwindow.h<br>
@@ -5,6 +5,7 @@<br>
* SPDX-FileCopyrightText: 2018-2020 Michael Reeves <a href="mailto:reeves.87@gmail.com" target="_blank" rel="noreferrer">reeves.87@gmail.com</a><br>
* SPDX-License-Identifier: GPL-2.0-or-later<br>
*/<br>
+//clazy:excludeall=connect-non-signal,incorrect-emit<br>
<br>
#ifndef DIFFTEXTWINDOW_H<br>
#define DIFFTEXTWINDOW_H<br>
diff --git a/src/directorymergewindow.cpp b/src/directorymergewindow.cpp<br>
index d44b0b5..f2dca29 100644<br>
--- a/src/directorymergewindow.cpp<br>
+++ b/src/directorymergewindow.cpp<br>
@@ -5,6 +5,8 @@<br>
* SPDX-FileCopyrightText: 2018-2020 Michael Reeves <a href="mailto:reeves.87@gmail.com" target="_blank" rel="noreferrer">reeves.87@gmail.com</a><br>
* SPDX-License-Identifier: GPL-2.0-or-later<br>
*/<br>
+//clazy:excludeall=connect-non-signal,incorrect-emit<br>
+<br>
#include "directorymergewindow.h"<br>
<br>
#include "DirectoryInfo.h"<br>
diff --git a/src/kdiff3.cpp b/src/kdiff3.cpp<br>
index a3320a6..3d89218 100644<br>
--- a/src/kdiff3.cpp<br>
+++ b/src/kdiff3.cpp<br>
@@ -5,6 +5,7 @@<br>
* SPDX-FileCopyrightText: 2018-2020 Michael Reeves <a href="mailto:reeves.87@gmail.com" target="_blank" rel="noreferrer">reeves.87@gmail.com</a><br>
* SPDX-License-Identifier: GPL-2.0-or-later<br>
*/<br>
+//clazy:excludeall=connect-non-signal,incorrect-emit<br>
<br>
// application specific includes<br>
#include "kdiff3.h"<br>
diff --git a/src/kdiff3.h b/src/kdiff3.h<br>
index 6b671c0..2e3ae09 100644<br>
--- a/src/kdiff3.h<br>
+++ b/src/kdiff3.h<br>
@@ -5,7 +5,7 @@<br>
* SPDX-FileCopyrightText: 2018-2020 Michael Reeves <a href="mailto:reeves.87@gmail.com" target="_blank" rel="noreferrer">reeves.87@gmail.com</a><br>
* SPDX-License-Identifier: GPL-2.0-or-later<br>
*/<br>
-<br>
+//clazy:excludeall=connect-non-signal,incorrect-emit<br>
#ifndef KDIFF3_H<br>
#define KDIFF3_H<br>
<br>
diff --git a/src/kdiff3_shell.cpp b/src/kdiff3_shell.cpp<br>
index b6ec641..da67232 100644<br>
--- a/src/kdiff3_shell.cpp<br>
+++ b/src/kdiff3_shell.cpp<br>
@@ -5,6 +5,7 @@<br>
* SPDX-FileCopyrightText: 2018-2020 Michael Reeves <a href="mailto:reeves.87@gmail.com" target="_blank" rel="noreferrer">reeves.87@gmail.com</a><br>
* SPDX-License-Identifier: GPL-2.0-or-later<br>
*/<br>
+//clazy:excludeall=connect-non-signal,incorrect-emit<br>
<br>
#include "kdiff3_shell.h"<br>
#include "kdiff3.h"<br>
diff --git a/src/mergeresultwindow.cpp b/src/mergeresultwindow.cpp<br>
index 5e58fb3..78151fe 100644<br>
--- a/src/mergeresultwindow.cpp<br>
+++ b/src/mergeresultwindow.cpp<br>
@@ -5,6 +5,7 @@<br>
* SPDX-FileCopyrightText: 2018-2020 Michael Reeves <a href="mailto:reeves.87@gmail.com" target="_blank" rel="noreferrer">reeves.87@gmail.com</a><br>
* SPDX-License-Identifier: GPL-2.0-or-later<br>
*/<br>
+//clazy:excludeall=connect-non-signal,incorrect-emit<br>
<br>
#include "mergeresultwindow.h"<br>
<br>
diff --git a/src/pdiff.cpp b/src/pdiff.cpp<br>
index 9670692..e2b2151 100644<br>
--- a/src/pdiff.cpp<br>
+++ b/src/pdiff.cpp<br>
@@ -5,6 +5,7 @@<br>
* SPDX-FileCopyrightText: 2018-2020 Michael Reeves <a href="mailto:reeves.87@gmail.com" target="_blank" rel="noreferrer">reeves.87@gmail.com</a><br>
* SPDX-License-Identifier: GPL-2.0-or-later<br>
*/<br>
+//clazy:excludeall=connect-non-signal,incorrect-emit<br>
<br>
#include "difftextwindow.h"<br>
#include "DirectoryInfo.h"<br>
diff --git a/src/smalldialogs.cpp b/src/smalldialogs.cpp<br>
index 5c12da3..df248a1 100644<br>
--- a/src/smalldialogs.cpp<br>
+++ b/src/smalldialogs.cpp<br>
@@ -4,6 +4,7 @@<br>
* SPDX-FileCopyrightText: 2002-2011 Joachim Eibl, joachim.eibl at <a href="http://gmx.de" rel="noreferrer noreferrer" target="_blank">gmx.de</a><br>
* SPDX-License-Identifier: GPL-2.0-or-later<br>
*/<br>
+//clazy:excludeall=connect-non-signal,incorrect-emit<br>
<br>
#include "smalldialogs.h"<br>
<br>
<br>
<br>
</div></div></div>