<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<style type="text/css" style="display:none;"> P {margin-top:0;margin-bottom:0;} </style>
</head>
<body dir="ltr">
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);" class="elementToProof">
Hi,</div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);" class="elementToProof">
<br>
</div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);" class="elementToProof">
Thanks for the review, I have fixed most of the issues mentioned in this list. Please review again.</div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);" class="elementToProof">
<br>
</div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);" class="elementToProof">
Regards,</div>
<div style="font-family: Calibri, Helvetica, sans-serif; font-size: 12pt; color: rgb(0, 0, 0); background-color: rgb(255, 255, 255);" class="elementToProof">
Aditya<br>
</div>
<div id="appendonsend"></div>
<hr style="display:inline-block;width:98%" tabindex="-1">
<div id="divRplyFwdMsg" dir="ltr"><font face="Calibri, sans-serif" style="font-size:11pt" color="#000000"><b>From:</b> Harald Sitter <sitter@kde.org><br>
<b>Sent:</b> Friday, August 26, 2022 10:43 PM<br>
<b>To:</b> Aditya Mehra <aix.m@outlook.com><br>
<b>Cc:</b> kde-core-devel <kde-core-devel@kde.org><br>
<b>Subject:</b> Re: Plasma Remote Controllers in KDE Review</font>
<div> </div>
</div>
<div class="BodyFragment"><font size="2"><span style="font-size:11pt;">
<div class="PlainText">- src dir is missing i18n setup (messages.sh and define in cmakelists)<br>
- not reuse covered<br>
- metainfo.xml missing (appstream)<br>
- doesn't have gitlab ci builds apparently?<br>
- doesn't have bugzilla product<br>
- clazy is not happy<br>
<br>
On Fri, Aug 26, 2022 at 12:21 PM Aditya Mehra <aix.m@outlook.com> wrote:<br>
><br>
> Hi,<br>
><br>
> Plasma remote controllers is in KDE Review and would like to release it along with Plasma Bigscreen<br>
><br>
> Plasma remote controllers allows translating various input device events into keyboard and pointer events send from remote control type devices like CEC and Gamepads to provide key navigation support in applications. It also allows re mapping of keys to specific
events.<br>
><br>
> You can find the repository here: <a href="https://invent.kde.org/plasma-bigscreen/plasma-remotecontrollers">
https://invent.kde.org/plasma-bigscreen/plasma-remotecontrollers</a><br>
><br>
> Request to please review Plasma remote controllers.<br>
><br>
> Regards,<br>
> Aditya<br>
</div>
</span></font></div>
</body>
</html>