<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<div class="noquote" style="color: rgb(35, 38, 41); font-family:
"Noto Sans"; font-size: 13px; font-style: normal;
font-variant-ligatures: normal; font-variant-caps: normal;
font-weight: 400; letter-spacing: normal; orphans: 2; text-align:
start; text-indent: 0px; text-transform: none; white-space:
normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width:
0px; background-color: rgb(255, 255, 255);
text-decoration-thickness: initial; text-decoration-style:
initial; text-decoration-color: initial;">
<div dir="ltr">On Monday, May 30, 2022 2:55:55 PM CEST Aleix Pol
wrote:</div>
</div>
<blockquote style="margin: 4pt 0px; padding: 0px 0px 0px 1em;
border-left: 2px solid rgb(33, 145, 80); unicode-bidi: plaintext;
color: rgb(35, 38, 41); font-family: "Noto Sans";
font-size: 13px; font-style: normal; font-variant-ligatures:
normal; font-variant-caps: normal; font-weight: 400;
letter-spacing: normal; orphans: 2; text-align: start;
text-indent: 0px; text-transform: none; white-space: normal;
widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px;
background-color: rgb(255, 255, 255); text-decoration-thickness:
initial; text-decoration-style: initial; text-decoration-color:
initial;">
<div class="quotelevel1" style="color: rgb(33, 145, 80)
!important; font-style: italic !important;">
<div dir="ltr"><span class="quotemarks" style="color:
transparent; font-size: 0px;">><span> </span></span><font
color="#219150">Hi,</font></div>
<div dir="ltr"><span class="quotemarks" style="color:
transparent; font-size: 0px;">><span> </span></span><font
color="#219150">I'd like to get KPipeWire (<a
href="https://invent.kde.org/plasma/kpipewire"
style="color: rgb(41, 128, 185) !important;
text-decoration: none !important;"
class="moz-txt-link-freetext">https://invent.kde.org/plasma/kpipewire</a>)</font></div>
<div dir="ltr"><span class="quotemarks" style="color:
transparent; font-size: 0px;">><span> </span></span><font
color="#219150">released from KDE eventually.</font></div>
<div dir="ltr"><span class="quotemarksemptyline" style="color:
transparent; font-size: 0px; line-height: 12pt;">></span></div>
<div dir="ltr"><span class="quotemarks" style="color:
transparent; font-size: 0px;">><span> </span></span><font
color="#219150">At the moment it's under Plasma as it's the
only place where it's</font></div>
<div dir="ltr"><span class="quotemarks" style="color:
transparent; font-size: 0px;">><span> </span></span><font
color="#219150">being used, I know we might want to use it
in spectacle eventually,</font></div>
<div dir="ltr"><span class="quotemarks" style="color:
transparent; font-size: 0px;">><span> </span></span><font
color="#219150">although I feel like it's premature to get
it in frameworks just yet,</font></div>
<div dir="ltr"><span class="quotemarks" style="color:
transparent; font-size: 0px;">><span> </span></span><font
color="#219150">although it should be a possibility down the
line.</font></div>
<div dir="ltr"><span class="quotemarksemptyline" style="color:
transparent; font-size: 0px; line-height: 12pt;">></span></div>
<div dir="ltr"><span class="quotemarks" style="color:
transparent; font-size: 0px;">><span> </span></span><font
color="#219150">If you wanted to test it beyond what Plasma
does, you can try this</font></div>
<div dir="ltr"><span class="quotemarks" style="color:
transparent; font-size: 0px;">><span> </span></span><font
color="#219150">little app for recording your wayland
desktops and windows.</font></div>
<div dir="ltr"><span class="quotemarks" style="color:
transparent; font-size: 0px;">><span> </span></span><font
color="#219150"><a
href="https://invent.kde.org/apol/screenrecord"
style="color: rgb(41, 128, 185) !important;
text-decoration: none !important;"
class="moz-txt-link-freetext">https://invent.kde.org/apol/screenrecord</a></font></div>
<div dir="ltr"><span class="quotemarksemptyline" style="color:
transparent; font-size: 0px; line-height: 12pt;">></span></div>
<div dir="ltr"><span class="quotemarks" style="color:
transparent; font-size: 0px;">><span> </span></span><font
color="#219150">Cheers!</font></div>
<div dir="ltr"><span class="quotemarks" style="color:
transparent; font-size: 0px;">><span> </span></span><font
color="#219150">Aleix</font></div>
</div>
</blockquote>
<div class="noquote" style="color: rgb(35, 38, 41); font-family:
"Noto Sans"; font-size: 13px; font-style: normal;
font-variant-ligatures: normal; font-variant-caps: normal;
font-weight: 400; letter-spacing: normal; orphans: 2; text-align:
start; text-indent: 0px; text-transform: none; white-space:
normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width:
0px; background-color: rgb(255, 255, 255);
text-decoration-thickness: initial; text-decoration-style:
initial; text-decoration-color: initial;"><br>
<div dir="ltr">Hi,</div>
<br>
<div dir="ltr">- The repo could use a README that explains what it
is and isn't</div>
<div dir="ltr">- The repo probably shouldn't have a .kdev4 file</div>
<div dir="ltr">- CMakeLists.txt states 5.20 as minimum ECM
version. That sounds wrong</div>
<div dir="ltr">- (some of) the pkg_check_modules calls should
probably have REQUIRED</div>
<div dir="ltr">- I get some build warnings:</div>
<br>
<div dir="ltr">[9/46] Building CXX object
src/CMakeFiles/KPipeWire.dir/pipewirecore.cpp.o</div>
<div dir="ltr">/home/nico/kde/src/kpipewire/src/pipewirecore.cpp:21:1:
warning: missing </div>
<div dir="ltr">initializer for member ‘pw_core_events::done’
[-Wmissing-field-initializers]</div>
<div dir="ltr"> 21 | };</div>
<div dir="ltr"> | ^</div>
<div dir="ltr">/home/nico/kde/src/kpipewire/src/pipewirecore.cpp:21:1:
warning: missing </div>
<div dir="ltr">initializer for member ‘pw_core_events::ping’
[-Wmissing-field-initializers]</div>
<div dir="ltr">/home/nico/kde/src/kpipewire/src/pipewirecore.cpp:21:1:
warning: missing </div>
<div dir="ltr">initializer for member ‘pw_core_events::remove_id’
[-Wmissing-field-</div>
<div dir="ltr">initializers]</div>
<div dir="ltr">/home/nico/kde/src/kpipewire/src/pipewirecore.cpp:21:1:
warning: missing </div>
<div dir="ltr">initializer for member ‘pw_core_events::bound_id’
[-Wmissing-field-</div>
<div dir="ltr">initializers]</div>
<div dir="ltr">/home/nico/kde/src/kpipewire/src/pipewirecore.cpp:21:1:
warning: missing </div>
<div dir="ltr">initializer for member ‘pw_core_events::add_mem’
[-Wmissing-field-initializers]</div>
<div dir="ltr">/home/nico/kde/src/kpipewire/src/pipewirecore.cpp:21:1:
warning: missing </div>
<div dir="ltr">initializer for member ‘pw_core_events::remove_mem’
[-Wmissing-field-</div>
<div dir="ltr">initializers]</div>
<br>
<div dir="ltr">- ecm_add_qtwayland_client_protocol can take a
target since recently</div>
<div dir="ltr">- xdp-recordme probably shouldn't be installed (by
default)?</div>
<div dir="ltr">- There's no FreeBSD CI yet</div>
<br>
<div dir="ltr">These are some minor things I noticed while
glossing over. I won't pretent to </div>
<div dir="ltr">understand enough about PipeWire to comment on the
actual code.</div>
<br>
<div dir="ltr">Cheers</div>
<br>
<div dir="ltr">Nico</div>
</div>
</body>
</html>