<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<div class="moz-text-flowed" style="font-family: -moz-fixed;
font-size: 12px;" lang="x-unicode">Formatting of my first reply
looks terrible in the web mailing list.</div>
<div class="moz-text-flowed" style="font-family: -moz-fixed;
font-size: 12px;" lang="x-unicode">Hopefully this one is better.
Sorry.<br>
</div>
<div class="moz-text-flowed" style="font-family: -moz-fixed;
font-size: 12px;" lang="x-unicode"><br>
</div>
<div class="moz-text-flowed" style="font-family: -moz-fixed;
font-size: 12px;" lang="x-unicode">On 20.07.2021 00:39, Albert
Astals Cid wrote:
<br>
<blockquote type="cite" style="color: #007cff;">El dilluns, 19 de
juliol de 2021, a les 14:54:26 (CEST), George Florea Banus va
escriure:
<br>
You need a
<br>
<br>
KLocalizedString::setApplicationDomain("haruna")
<br>
<br>
just after creating your QApplication. Otherwise translations
are not going to be loaded.
<br>
</blockquote>
<br>
Done. <br>
</div>
<div class="moz-text-flowed" style="font-family: -moz-fixed;
font-size: 12px;" lang="x-unicode"><br>
<blockquote type="cite" style="color: #007cff;">The menus
look&feel is a bit broken (separators and highlight being
drawn past the actual menu width, icons being painted
"blurrily"), but i guess that's not really your fault.
<br>
</blockquote>
<br>
Nothing done here. <br>
</div>
<div class="moz-text-flowed" style="font-family: -moz-fixed;
font-size: 12px;" lang="x-unicode"><br>
<blockquote type="cite" style="color: #007cff;">The Setting has a
"Help!" <- remove the !
<br>
</blockquote>
<br>
Done. <br>
</div>
<div class="moz-text-flowed" style="font-family: -moz-fixed;
font-size: 12px;" lang="x-unicode"><br>
<blockquote type="cite" style="color: #007cff;">in that "Help!"
menu you have a KHelpCenter entry that should be called "Haruna
handbook" like in the rest of applications.
<br>
</blockquote>
<br>
Done. <br>
</div>
<div class="moz-text-flowed" style="font-family: -moz-fixed;
font-size: 12px;" lang="x-unicode"><br>
<blockquote type="cite" style="color: #007cff;">The first time i
open the app the "Color scheme" combo box doesn't have contents,
given there's a default entry i'd expect to see that.
<br>
</blockquote>
<br>
I encountered a weird issues here. The color scheme is saved to
the "ColorScheme" entry <a class="moz-txt-link-freetext"
href="https://invent.kde.org/multimedia/haruna/-/blob/master/src/settings/generalsettings.kcfg#L46">https://invent.kde.org/multimedia/haruna/-/blob/master/src/settings/generalsettings.kcfg#L46</a>
<br>
But the default value for "GeneralSettings::colorScheme()" is
BreezeLight, even if I set a default value.
<br>
If I rename the entry, for example to "ColorScheme123" then it
gets the correct default value.
<br>
Or if I move it to another settings class like MouseSettings, then
it also gets the correct default value. <br>
</div>
<div class="moz-text-flowed" style="font-family: -moz-fixed;
font-size: 12px;" lang="x-unicode"><br>
<blockquote type="cite" style="color: #007cff;">The "english only"
help is kind of weird. Why are you using html for that? Seems
like something you should do with tooltips and if those QML
components don't support tooltips, at least make the help page
with QML so it's translatable?
<br>
</blockquote>
<br>
That's what I used before adding the docbook file. The content of
the html pages are the same as the content in the docbook.
<br>
I kept them because the KHelpCenter doesn't render the html
correctly.
<br>
Sometimes there's no space between words, if rows are long enough
they get behind the scrollbar, there's no bold.
<br>
As for why not use tooltips, sometimes there's just to much text.
<a class="moz-txt-link-freetext"
href="https://invent.kde.org/multimedia/haruna/-/blob/master/help/VideoSettings.html">https://invent.kde.org/multimedia/haruna/-/blob/master/help/VideoSettings.html</a></div>
<div class="moz-text-flowed" style="font-family: -moz-fixed;
font-size: 12px;" lang="x-unicode"> <br>
<blockquote type="cite" style="color: #007cff;">I've no idea what
the "Open config..." entries in the settings menu are supposed
to do, but both fail with "file doesn't exist" for me.</blockquote>
<br>
They open the config file and config folder, but it tried to open
a wrong path, I fixed that now.
<br>
And now it's also hidden when the config folder doesn't exist. <br>
</div>
<div class="moz-text-flowed" style="font-family: -moz-fixed;
font-size: 12px;" lang="x-unicode"><br>
<blockquote type="cite" style="color: #007cff;">Esc not only exits
fullscreen (good) but enters fullscreen (weird).
<br>
</blockquote>
<br>
Fixed. <br>
</div>
<div class="moz-text-flowed" style="font-family: -moz-fixed;
font-size: 12px;" lang="x-unicode"><br>
<blockquote type="cite" style="color: #007cff;">The "Primary
Subtitle" MenuItem that tries to be a title is kind of weird
because it has exactly the same look&feel that the other
menus, at least disable clicking on it, because i can click on
it and then it's even more confusing if it's really wants to be
a title or not without reading the code :D
<br>
</blockquote>
<br>
Yes, it's used as title. I wanted to change that menu, but
couldn't come with anything better.
<br>
I think I'll change it so it manages only the primary subtitle. <br>
</div>
<div class="moz-text-flowed" style="font-family: -moz-fixed;
font-size: 12px;" lang="x-unicode"><br>
<blockquote type="cite" style="color: #007cff;">It does remember
the last thing i was playing, which I dislike, I tried to look
for a config option to disable it but doesn't seem to be one.
Feel free to ignore this.
<br>
</blockquote>
<br>
I'll add an option to disable that behavior, someone else
requested it too. <br>
</div>
<div class="moz-text-flowed" style="font-family: -moz-fixed;
font-size: 12px;" lang="x-unicode"><br>
<blockquote type="cite" style="color: #007cff;">The thing you call
Header in View -> "Hide header" is called historically called
toolbar, i think you should rename it.
<br>
</blockquote>
<br>
I'll called it header because that's what Qt calls it and the
footer is also a toolbar.
<br>
Do you want me to change only user facing part or everything?
What about the footer? <br>
</div>
<div class="moz-text-flowed" style="font-family: -moz-fixed;
font-size: 12px;" lang="x-unicode"><br>
<blockquote type="cite" style="color: #007cff;">All in all, the
app is nice, but IMHO suffers a bit from being QML based and not
being able to use KXMLGUI.
<br>
<br>
Cheers,
<br>
Albert
<br>
</blockquote>
<br>
Thanks for the review.
<br>
<br>
<br>
</div>
</body>
</html>