<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
On 01.11.20 12:29, Albert Astals Cid wrote:
<br>
<blockquote type="cite" style="color: #007cff;">El dijous, 29
d’octubre de 2020, a les 0:34:30 CET, Tobias Fella va escriure:
<br>
<blockquote type="cite" style="color: #007cff;">Hi all,
<br>
<br>
I've moved Alligator to KDEReview.
<br>
<br>
Alligator is an RSS feed reader I started developing because of
the need
<br>
for a feed reader for plasma mobile (and to waste some time
during
<br>
corona). Since it's built using kirigami, it's usable on both
mobile and
<br>
desktop. I've also ported it to android, where it works quite
nicely.
<br>
<br>
It still has some problems with correctly rendering some feeds
because
<br>
of the limited html & css subset supported by the QML label,
but I'm
<br>
working around those.
<br>
</blockquote>
Any reason you're not using WebEngineView ?
<br>
</blockquote>
<br>
I'm not using Webengine because i want it to work on Android and
using WebView I didn't get nice results due to other problems
<br>
<br>
<blockquote type="cite" style="color: #007cff;">
<br>
<blockquote type="cite" style="color: #007cff;">If you find feeds
that don't render nicely (for
<br>
example where images are not limited to the page width), feel
free to
<br>
send them my way.
<br>
<br>
If you want to try it, you can get android and flatpak builds
from the
<br>
binary factory.
<br>
<br>
For releases, i plan on getting it into release service in time
for
<br>
20.12. Before that, I'll probably release a beta version
<br>
</blockquote>
I'm not convinced you're in time for that, technically one could
argue that you can join up to November 12 that is when we have the
Feature Freeze, but for me it makes sense to only release things
that are ready on Nov 5, which is really soon.
<br>
<br>
<a class="moz-txt-link-freetext"
href="https://community.kde.org/Policies/Application_Lifecycle">https://community.kde.org/Policies/Application_Lifecycle</a>
says 2 weeks of kdereview.
<br>
<br>
I don't want to be the bad cop, but i'd say you're 1 week late.
<br>
</blockquote>
<br>
Yes I realized that after sending the email... Next release after
that it is, then
<br>
<br>
<blockquote type="cite" style="color: #007cff;">
<blockquote type="cite" style="color: #007cff;">Since I'm still a
beginner at programming with Qt/cpp/qml, I'd
<br>
appreciate comments or suggestions on my code <span
class="moz-smiley-s3" title=";)"></span>
<br>
</blockquote>
You're missing KLocalizedString::setApplicationDomain in your
main.cpp
<br>
<br>
You're not deleteing the Author you create on Entry::Entry, i'm
guessing a qDeleteAll(m_authors); in the destructor is what you
want.
<br>
<br>
Similarly you seem to also need a qDeleteAll(m_entries) in
EntriesModel destructor
<br>
<br>
clazy reports a few missing const & in your args, not that it
really matters, but it'll be 0.000000000000001% faster which means
saving 0.0000000000000000001% battery if you're using it in a
phone :D <a class="moz-txt-link-freetext"
href="https://paste.debian.net/1169487/">https://paste.debian.net/1169487/</a>
<br>
</blockquote>
Will fix
<br>
<blockquote type="cite" style="color: #007cff;">This animation feels
super weird, is this something you can control or Kirigami
provided?
<br>
<a class="moz-txt-link-freetext"
href="https://i.imgur.com/rleJfso.gif">https://i.imgur.com/rleJfso.gif</a>
<br>
</blockquote>
<br>
I wouldn't call that an animation, it's just the page closing and a
new one opening <span class="moz-smiley-s3" title=";)"></span> I
can probably make that nicer by changing the content of the current
page instead of replacing it.
<br>
<br>
<br>
Thanks for your review,
<br>
<br>
<br>
Tobias
<br>
<br>
<br>
Cheers,
<br>
Albert
<br>
<br>
<blockquote type="cite" style="color: #007cff;">Thanks,
<br>
<br>
Tobias
<br>
<br>
<br>
<a class="moz-txt-link-freetext"
href="https://invent.kde.org/plasma-mobile/alligator">https://invent.kde.org/plasma-mobile/alligator</a>
<br>
<br>
<a class="moz-txt-link-freetext"
href="https://binary-factory.kde.org/job/Alligator_android/">https://binary-factory.kde.org/job/Alligator_android/</a>
<br>
<br>
<a class="moz-txt-link-freetext"
href="https://binary-factory.kde.org/job/Alligator_x86_64_flatpak/">https://binary-factory.kde.org/job/Alligator_x86_64_flatpak/</a>
<br>
<br>
<br>
</blockquote>
<br>
</body>
</html>