<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/130239/">https://git.reviewboard.kde.org/r/130239/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On setembre 26th, 2017, 6:02 p.m. UTC, <strong>Albert Astals Cid</strong> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/130239/diff/2/?file=513534#file513534line61" style="color: black; font-weight: bold; text-decoration: underline;">cmake/modules/Win32Macros.cmake</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">61</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="s">MACRO</span> <span class="p">(</span><span class="s">set_execution_level_as_invoker</span> <span class="s">_source</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I don't think it makes sense adding a new public-ish macro in 4.14.lots</p></pre>
</blockquote>
<p>On setembre 26th, 2017, 6:16 p.m. UTC, <strong>Ralf Habacker</strong> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">See revision 1 of this patch at https://git.reviewboard.kde.org/r/130239/diff/1/</p></pre>
</blockquote>
<p>On setembre 26th, 2017, 6:47 p.m. UTC, <strong>Albert Astals Cid</strong> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm personally happier with that patch for almost dead 4.14 (it has 2 releases left), now you're going to need someone with a win32 build/knowledge to approve since honestly i have no idea what this does.</p></pre>
</blockquote>
<p>On setembre 27th, 2017, 9:15 a.m. UTC, <strong>Ralf Habacker</strong> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">for almost dead 4.14 (it has 2 releases left),</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looking at the number of open KF5 related windows issues I guess kmymoney and umbrello for Windows will depends on KDE4 at least a year. </p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">i have no idea what this does.</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">From https://stackoverflow.com/questions/20096706/how-does-windows-decide-whether-to-display-the-uac-prompt</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">kconf_update is "hitting a Windows Installer Detection Technology compatibility heuristic. Windows will try to detect when an application is an installer, and probably needs to be elevated."</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">BTW: The same issue happens also with KF5</p></pre>
</blockquote>
<p>On setembre 27th, 2017, 10:43 a.m. UTC, <strong>Alexey Min</strong> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This looks good and harmless actually. As I understood, it adds a .rc (windows resource file) with embedded manifest resource, saying that no elevation is needed for this .exe file.
We at our work also had problems with this windows heuristic (we had a helper program, containing "setup" in its name, so it magically required administrator rights with no real need for this).
So if this really works and helps for windows, why not.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looking at the number of open KF5 related windows issues I guess kmymoney and umbrello for Windows will depends on KDE4 at least a year. </p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">That has nothing to do with kdelibs 4.14.x not being released anymore after KDE Applications 17.08.3, which is what i said</p></pre>
<br />
<p>- Albert</p>
<br />
<p>On setembre 27th, 2017, 9:19 a.m. UTC, Ralf Habacker wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kdelibs and Albert Astals Cid.</div>
<div>By Ralf Habacker.</div>
<p style="color: grey;"><em>Updated set. 27, 2017, 9:19 a.m.</em></p>
<div style="margin-top: 1.5em;">
<strong style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </strong>
<a href="http://bugs.kde.org/show_bug.cgi?id=384334">384334</a>
</div>
<div style="margin-top: 1.5em;">
<strong style="color: #575012; font-size: 10pt;">Repository: </strong>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch fixes an issue that on the first start of KMyMoney (and on some computers on every start for example reported by https://forum.kde.org/viewtopic.php?f=69&t=141673&sid=ba4dcaa26018f16e19d21c58c34ad4e9) on running kconf_update the user account control pops up and forces the user to allow or deny this application.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Commit message</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Add Windows manifest to kconf_update.exe</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span></span>This explicitly sets the execution level to 'asInvoker', preventing
Windows' UAC heuristics from deciding that because its name mentions
"update", it probably needs to escalate privileges.
FIXED-IN:4.14.36
BUG:384334
</pre></div>
</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Compiled at https://build.opensuse.org/package/show/windows%3Amingw%3Awin32/mingw32-kdelibs4 and tested with KMyMoney snapshot for Windows downloadable from https://software.opensuse.org/package/mingw32-kmymoney-portable</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kconf_update/CMakeLists.txt <span style="color: grey">(6bf3bf1f923baf11aad63e10fe249d70ce1b4d33)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/130239/diff/3/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>