<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118366/">https://git.reviewboard.kde.org/r/118366/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Seems this was somehow forgotten, sadly the patch does not apply anymore (or maybe it was commited and this was never closed?).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Could you either upload a new patch if it's still needed or close the review if it is now?</p></pre>
<br />
<p>- Albert Astals Cid</p>
<br />
<p>On June 23rd, 2014, 1:46 p.m. UTC, shivam makkar wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kde-workspace, KDE Frameworks and Andriy Rysin.</div>
<div>By shivam makkar.</div>
<p style="color: grey;"><i>Updated June 23, 2014, 1:46 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Removed deprecated statements and ported keyboard module to framework 5.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcms/keyboard/bindings.h <span style="color: grey">(c5764556d97e06ebad4f1737ffbbea2981ff32ca)</span></li>
<li>kcms/keyboard/bindings.cpp <span style="color: grey">(21541e095da0b8d6ea1f789644f6e09d577c298b)</span></li>
<li>kcms/keyboard/flags.cpp <span style="color: grey">(b768586cc644fc5750245a8b1c3db4c55a43c16e)</span></li>
<li>kcms/keyboard/iso_codes.h <span style="color: grey">(6a337392e958546e9f36423d7e3fd10d9e12c6f8)</span></li>
<li>kcms/keyboard/iso_codes.cpp <span style="color: grey">(3e3b210b9f0f89c71a04535e74bd43b6b3b243e9)</span></li>
<li>kcms/keyboard/kcm_keyboard.cpp <span style="color: grey">(42b7fe4df5fddd9ae738cde62d0c9e8a3dcad103)</span></li>
<li>kcms/keyboard/kcm_keyboard.ui <span style="color: grey">(0062d1c53877f13d0036c0220691347434a9d47f)</span></li>
<li>kcms/keyboard/kcm_keyboard_widget.h <span style="color: grey">(657ddda3bc1d75a632a6ddbd1a9ec690b6244909)</span></li>
<li>kcms/keyboard/kcm_keyboard_widget.cpp <span style="color: grey">(21685eb527b7fd1d8a322d0e17ae2c0ae291ce41)</span></li>
<li>kcms/keyboard/kcmmisc.h <span style="color: grey">(411bdd2b0f61257b4382fe35be4b8fa4ea2ecba6)</span></li>
<li>kcms/keyboard/kcmmisc.cpp <span style="color: grey">(6f787ea3723f223537252b9581c15db203f4764c)</span></li>
<li>kcms/keyboard/kcmmiscwidget.ui <span style="color: grey">(37fbaf4b9c9af9a62713bb9b5444cc04320e8d53)</span></li>
<li>kcms/keyboard/keyboard_config.h <span style="color: grey">(b86418de47a83e75eb85e723cc8eb24071e1f43d)</span></li>
<li>kcms/keyboard/keyboard_config.cpp <span style="color: grey">(f3ff97ca84d444acfb215a32bb900815318aefd9)</span></li>
<li>kcms/keyboard/keyboard_daemon.h <span style="color: grey">(4edb968bb071445c52332c695e7978d26363ad09)</span></li>
<li>kcms/keyboard/keyboard_daemon.cpp <span style="color: grey">(25673b073e104357cb3d56b13688ef7d790ee8cd)</span></li>
<li>kcms/keyboard/keyboard_hardware.cpp <span style="color: grey">(dca49b674083dbae6398e8ba0e524c647a36e47a)</span></li>
<li>kcms/keyboard/layout_memory.h <span style="color: grey">(df8568c2bdb82f0be713424e1cf6404761312ea5)</span></li>
<li>kcms/keyboard/layout_memory.cpp <span style="color: grey">(9e723612b75b82fb04ac1fd5c2271e58e3c1aaf7)</span></li>
<li>kcms/keyboard/layout_memory_persister.h <span style="color: grey">(8c4b3c5f60277c319b4d94ad3d40b1a65b706b8d)</span></li>
<li>kcms/keyboard/layout_memory_persister.cpp <span style="color: grey">(8a6118aad9edea5c6a4a627144c3fd3bf837fe0e)</span></li>
<li>kcms/keyboard/layout_widget.cpp <span style="color: grey">(e67b2d77d32b87339003285712b6ef98fc292bd3)</span></li>
<li>kcms/keyboard/layouts_menu.h <span style="color: grey">(db2f3ff5844e16340ad3ca6102e6b1c4866ad8db)</span></li>
<li>kcms/keyboard/layouts_menu.cpp <span style="color: grey">(fd436c406671dcbb859dcb7367b9c83fba99da0c)</span></li>
<li>kcms/keyboard/x11_helper.h <span style="color: grey">(719b13fec63265e0c0fed01c21e197349305928e)</span></li>
<li>kcms/keyboard/x11_helper.cpp <span style="color: grey">(0e2806eeb55e4987c2b8f528d026ec5864d2dd9c)</span></li>
<li>kcms/keyboard/xinput_helper.h <span style="color: grey">(343d7ed2a0528459069b0b2e3a3d4aa4d8ce43d8)</span></li>
<li>kcms/keyboard/xinput_helper.cpp <span style="color: grey">(b311579d1b65f3068d0c25b180bc1dd88fe7ba65)</span></li>
<li>kcms/keyboard/xkb_helper.cpp <span style="color: grey">(967399ebca42e3cd18b441152a0cf3a31e28b131)</span></li>
<li>kcms/keyboard/xkb_rules.h <span style="color: grey">(2be856246cc150abb24775c6d56b8af2a07df94f)</span></li>
<li>kcms/keyboard/xkb_rules.cpp <span style="color: grey">(f09e6750130799d6e0cdc380a6dbaa834c43aa43)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118366/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>