<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129208/">https://git.reviewboard.kde.org/r/129208/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 17th, 2016, 12:13 p.m. UTC, <b>Aleix Pol Gonzalez</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm not sure it's a very good idea to introduce behavior changes in kdelibs 4. Why can't you use kde-open from kf5?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Because I'm running KDE4 on many machines and want this bug fixed. It's not a solution to switch the newer OS and KDE version.
I think there are still many KDE4 users out there (debian wheezy).
Also I'm not sure if this is fixed in KF5. We should check that, but I don't have if it running here. Can you verify that this is fixed in KF5?</p></pre>
<br />
<p>- Gerhard</p>
<br />
<p>On October 17th, 2016, 10:18 a.m. UTC, Gerhard Gappmeier wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Gerhard Gappmeier.</div>
<p style="color: grey;"><i>Updated Oct. 17, 2016, 10:18 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">RFC3986 defines the following syntax for URI schemes
scheme = alpha *( alpha | digit | "+" | "-" | "." )
The '.' was missing which leaded to the problem that
xdg-open opc.tcp://localhost didn't work.
Background:
xdg-open calls kde-open which then uses KUrl and so leaded to this
problem. Of course this bug may affect also many other locations
using KUrl::isRelativeUrl.
This fix also adds a unit test to test the fix and avoid future
regressions.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdecore/io/kurl.cpp <span style="color: grey">(d9661eab5f8df3bfbbd2900246437fb129037dba)</span></li>
<li>kdecore/tests/kurltest.cpp <span style="color: grey">(3947724bfd1d26ad69b97789205a814a8d712591)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129208/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>