<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/128803/">https://git.reviewboard.kde.org/r/128803/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes, kde-baseapps should be split. Can you move all this to kde-baseapps/konqueror/doc instead? Sorry for the trouble.</p></pre>
<br />
<p>- David Faure</p>
<br />
<p>On August 30th, 2016, 2:01 p.m. UTC, Burkhard Lück wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Base Apps and David Faure.</div>
<div>By Burkhard Lück.</div>
<p style="color: grey;"><i>Updated Aug. 30, 2016, 2:01 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">doc/kcontrol/bookmarks/ doc/kcontrol/filemanager/ doc/kcontrol/history/ doc/kcontrol/kcmcss/ doc/kcontrol/khtml-adblock/ doc/kcontrol/khtml-behavior/ doc/kcontrol/khtml-general/ doc/kcontrol/khtml-java-js/ doc/kcontrol/khtml-plugins/ doc/kcontrol/performance/
splitted from kde-runtime master using https://github.com/ajdruff/git-splits</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Not included in build so far, the CMakeLists.txt and the dtd have to be adapted to kf5</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If this is pushed to kde-baseapps master, the kcontrol subdirs in plasma-desktop have to be removed, see https://git.reviewboard.kde.org/r/128685/</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">history looks good, see git-log-doc-kcontrol.txt</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>doc/kcontrol/bookmarks/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kcontrol/bookmarks/index.docbook <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kcontrol/filemanager/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kcontrol/filemanager/index.docbook <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kcontrol/history/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kcontrol/history/index.docbook <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kcontrol/kcmcss/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kcontrol/kcmcss/index.docbook <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kcontrol/khtml-adblock/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kcontrol/khtml-adblock/index.docbook <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kcontrol/khtml-behavior/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kcontrol/khtml-behavior/index.docbook <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kcontrol/khtml-general/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kcontrol/khtml-general/index.docbook <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kcontrol/khtml-java-js/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kcontrol/khtml-java-js/index.docbook <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kcontrol/khtml-plugins/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kcontrol/khtml-plugins/index.docbook <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kcontrol/performance/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>doc/kcontrol/performance/index.docbook <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/128803/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2016/08/30/fd446511-8b66-48c3-ab4f-97086d79f090__git-log-doc-kcontrol.txt">git-log-doc-kcontrol.txt</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>