<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127515/">https://git.reviewboard.kde.org/r/127515/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 29th, 2016, 9:02 a.m. CEST, <b>David Faure</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes you can push further cleanups directly.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thanks, I'm updating the review with the required changes for references and then I will push it.</p></pre>
<br />
<p>- Luigi</p>
<br />
<p>On March 28th, 2016, 6:06 p.m. CEST, Luigi Toscano wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Base Apps and David Faure.</div>
<div>By Luigi Toscano.</div>
<p style="color: grey;"><i>Updated March 28, 2016, 6:06 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Starting point: the output of convert-kcmdlineargs.pl
Then cleanups: moved statements as suggested by scripts comments; converted the remaining items (ki18n, etc); fixed headers; added consts, QStringLiteral, translation domain; fixed termination on parser validity errors (away from KCmdLineArgs::usage); etc, etc.
Set keditbookmarks version to 5.0.
Explicitly added KI18n and CoreAddons to the required libraries (cmake).
Commented out app.disableSessionManagement in kbookmarkmerger for now (probably not critical anyway).
-----------------
If this proves to be correct, can I push directly push further porting commits/cleanups to keditbookmarks (hoping for a standalone KF5 release in the not far future) or do you prefer to review all changes?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Compile, the two programs can run, now with proper version details. No apparent regression in parameter parsing.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>keditbookmarks/CMakeLists.txt <span style="color: grey">(b44f389)</span></li>
<li>keditbookmarks/kbookmarkmerger.cpp <span style="color: grey">(5f17a98)</span></li>
<li>keditbookmarks/main.cpp <span style="color: grey">(4302318)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127515/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>