<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125529/">https://git.reviewboard.kde.org/r/125529/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On October 5th, 2015, 2:46 p.m. UTC, <b>Hrvoje Senjan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As this is a behvioral change (well, closest categorisation), i would avoid merging this to kdelibs4, and mail kde-distro-packagers with a link to this review instead ;-)</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yeah, I pretty much agree but I thought I'd post it all the same to see if someone actually strongly objects xD</p></pre>
<br />
<p>- Harald</p>
<br />
<p>On October 5th, 2015, 2:21 p.m. UTC, Harald Sitter wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kdelibs and Jonathan Riddell.</div>
<div>By Harald Sitter.</div>
<p style="color: grey;"><i>Updated Oct. 5, 2015, 2:21 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This enables tighter integration with default Plasma 5 appearance in all
cases, previously all KDE4 applications would be themed using the Plasma 5
Breeze style through a kconf_update script called kde4breeze. This util
writes configs into the user home to make sure KDE4 apps appear breeze
themed. Unfortunately this does not work with sudo'd applications as they
would use a different HOME and thus use the Oxygen theme by default, making
them not fit in with the rest of the default theming.
The patch switches the default icon theme as well as widget style
from oxygen to breeze.
It also adjusts the hardcoded default color values in kcolorscheme from
oxygen to breeze
(thanks to Kai Uwe Broulik https://git.reviewboard.kde.org/r/124872/)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/colors/kcolorscheme.cpp <span style="color: grey">(a6650ace52117c4abcfc1893228dc23e3ab6299a)</span></li>
<li>kdeui/icons/kicontheme.cpp <span style="color: grey">(d9efbb0275e1094c887bb62382d5ddb4135684d7)</span></li>
<li>kdeui/kernel/kstyle.cpp <span style="color: grey">(95a71c24842338fbe6bf5128f6fb76029960b64a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125529/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>