<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125097/">https://git.reviewboard.kde.org/r/125097/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On September 10th, 2015, 11:29 p.m. CEST, <b>andreas kainz</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">hi, we have
hint https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/hint.svg and
visibility https://dl.dropboxusercontent.com/u/1642456/VDG/KF5/visibility.svg
in the kde:breeze Plasma/5.4 brunch and on 13.09. in master.</p></pre>
</blockquote>
<p>On September 11th, 2015, 12:25 a.m. CEST, <b>Roman Gilg</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hi! Were these icons already planned for this switch? To be honest, I normally wouldn't care which icong goes there, I just want an icon there. But one thing makes me a little doubtful about these icons: Don't you think an eye, striked or not, always starring at you from the top of the file explorer will be a little disturbing? Especially when you increase the size of the icons.
But if the dolphin devs want this icon or you more (I don't know who decides this), I would change my other review request and link to thes icons instead. :)</p></pre>
</blockquote>
<p>On September 11th, 2015, 12:35 a.m. CEST, <b>andreas kainz</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I discussed it with Uri the main icon designer. he would prefere the hint icon. the icon from Roman is good but it could also be an cut icon.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I don't know who decides this</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Our awesome visual design group ;)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This review request can be discarded then?</p></pre>
<br />
<p>- Emmanuel</p>
<br />
<p>On September 10th, 2015, 10:19 p.m. CEST, Roman Gilg wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kde-workspace, andreas kainz and Emmanuel Pescosta.</div>
<div>By Roman Gilg.</div>
<p style="color: grey;"><i>Updated Sept. 10, 2015, 10:19 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
breeze
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Icon is based on 'edit-copy.svg'. This icon is a follow up to my first review request https://git.reviewboard.kde.org/r/125094/
which I opened because Dolphin missed an icon for its switch to see hidden files.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Tested on Arch, Plasma 5.4.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>icons-dark/actions/22/hidden-files.svg <span style="color: grey">(PRE-CREATION)</span></li>
<li>icons/actions/16/hidden-files.svg <span style="color: grey">(PRE-CREATION)</span></li>
<li>icons/actions/22/hidden-files.svg <span style="color: grey">(PRE-CREATION)</span></li>
<li>icons-dark/actions/16/hidden-files.svg <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125097/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/09/07/9e208176-204f-4ab1-8fd5-6eef57bc10f4__change.png">Demonstration in Breeze</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>