<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123806/">https://git.reviewboard.kde.org/r/123806/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On Mai 21st, 2015, 5:02 nachm. UTC, <b>Patrick Eigensatz</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/123806/diff/7/?file=370396#file370396line24" style="color: black; font-weight: bold; text-decoration: underline;">klipper/klipper.kcfg</a>
<span style="font-weight: normal;">
(Diff revision 7)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">24</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <entry name="AllowWhitespaceEntries" type="Bool"></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><strong style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Question:</strong> Compiled plasma-workspace using <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">kdesrc-build --include-dependencies plasma-workspace</em>, applied patch and compiled again.
-> Build broken because g++ could not
locate <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">klippersettings.h</em> included in <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">historyitem.cpp</em>. Shouldn't this file be generated by <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">cmake</em>?
If I generate <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">klippersettings{.h,.cpp}</em> using <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">kconfig_compiler klipper.kcfg klippersettings.kcfgc</em> and run <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">kdesrc</em> again,
I get a build error:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">CMakeFiles<span style="color: #666666">/</span>testHistory.dir<span style="color: #666666">/</span>__<span style="color: #666666">/</span>historyitem.cpp.o<span style="color: #666666">:</span> In <span style="color: #008000; font-weight: bold">function</span> <span style="border: 1px solid #FF0000">`</span>KlipperSettings<span style="color: #666666">::</span>allowWhitespaceEntries()<span style="color: #BA2121">':</span>
<span style="color: #BA2121">/home/patrick/kdesrc/plasma-workspace/klipper/klippersettings.h:72: undefined reference to `KlipperSettings::self()'</span>
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Note: The whole file is full of <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">return self()->member</em>, I don't know why it fails on line 72 if it worked
the for last 20 members. (I didn't change anything, original kconfig_compiler output)</p></pre>
</blockquote>
<p>On Mai 21st, 2015, 10:36 nachm. UTC, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Shouldn't this file be generated by cmake?</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes, in the build dir.</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I get a build error:</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">That's a linker error. No idea about the actual reason (w/o seeing the source), but kconfig_compiler_kf5 should be used to generate that file.
I assume you don't have that tool and that's why the config build failed in the first place?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Arch ships it with the kconfig package, your distro might have it in some kconfig-dev?</p></pre>
</blockquote>
<p>On Mai 22nd, 2015, 2:46 nachm. UTC, <b>Patrick Eigensatz</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Do you know why I manually have to generate the files?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm on Arch and I've already installed the kconfig package, using kconfig_compiler_kf5 it doesn't compile neither.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span style="color: #BC7A00">[</span> <span style="color: #666666">38%</span><span style="color: #BC7A00">]</span> CMakeFiles<span style="color: #666666">/</span>testHistory.dir<span style="color: #666666">/</span>__<span style="color: #666666">/</span>historyitem.cpp.o<span style="color: #666666">:</span> In <span style="color: #008000; font-weight: bold">function</span> <span style="border: 1px solid #FF0000">`</span>KlipperSettings<span style="color: #666666">::</span>allowWhitespaceEntries()<span style="color: #BA2121">':</span>
<span style="color: #BA2121">/home/patrick/kdesrc/plasma-workspace/klipper/klippersettings.h:73: undefined reference to `KlipperSettings::self()'</span>
collect2<span style="color: #666666">:</span> Fehler<span style="color: #666666">:</span> ld gab <span style="color: #666666">1</span> als Ende<span style="color: #666666">-</span>Status zurück
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">(I'm sorry for german error log)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Should I post the source code somewhere? (KDE Paste, Pastebin?)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thank you in advance!</p></pre>
</blockquote>
<p>On Mai 22nd, 2015, 2:50 nachm. UTC, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">https://paste.kde.org/ but it's weird enough that you "need" to generate that file yourself - notably if this is only the case after your patch?</p></pre>
</blockquote>
<p>On Mai 22nd, 2015, 3:16 nachm. UTC, <b>Patrick Eigensatz</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes, building up-to-date repo works fine. (~ 10 minutes)
Applying patch <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">git am patch.patch</code>, building failes after 2 minutes.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">klipper/generalconfig.ui https://paste.kde.org/pksckllah
klipper/historyitem.cpp https://paste.kde.org/pfh1puwqu
klipper/klipper.cpp https://paste.kde.org/pp8psqys1
klipper/klipper.h https://paste.kde.org/pucpi5ri7
klipper/klipper.kcfg https://paste.kde.org/paemgof0i</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Generated files using kconfig_compiler_kf5:
klipper/klippersettings.h https://paste.kde.org/pyzsmwvf4
klipper/klippersettings.cpp https://paste.kde.org/psldgyqbg</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Build Log:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">https://paste.kde.org/piqztg5eu</p></pre>
</blockquote>
<p>On Mai 22nd, 2015, 6:33 nachm. UTC, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Linking CXX executable testHistory
Linking CXX executable testHistoryModel</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It's not klipper, it's the unit tests.
check the autotest directory, you'll have to add</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">kconfig_add_kcfg_files(testHistory_SRCS ../klippersettings.kcfgc)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">and</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">kconfig_add_kcfg_files(testHistoryModel_SRCS ../klippersettings.kcfgc)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">there. This will build create the settings sources, build and link them.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I've added this to the CMakeLists file. It seems as if it would create the config files now, but they seem to be invalid</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">/home/patrick/src/kde/build/plasma-workspace/klipper/autotests/klippersettings.cpp: In statischer Elementfunktion »static KlipperSettings* KlipperSettings::self()«:
/home/patrick/src/kde/build/plasma-workspace/klipper/autotests/klippersettings.cpp:21:35: Fehler: »class KlipperSettings« hat kein Element namens »read«
s_globalKlipperSettings()->q->read();
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Please have a look at the build file: https://paste.kde.org/pmptt6bdd</p></pre>
<br />
<p>- Patrick</p>
<br />
<p>On Mai 21st, 2015, 5 nachm. UTC, Patrick Eigensatz wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kde-workspace, KDE Usability and Patrick Eigensatz.</div>
<div>By Patrick Eigensatz.</div>
<p style="color: grey;"><i>Updated Mai 21, 2015, 5 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=159267">159267</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=192922">192922</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">[PATCH] plasma-workspace: klipper: Fix #192922 Ignore blank entries</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">QString::isEmpty() is used to check if the string only consists of whitespace characters. If it does, the creation of the HistoryStringItem fails.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>klipper/generalconfig.ui <span style="color: grey">(f513e9c)</span></li>
<li>klipper/historyitem.cpp <span style="color: grey">(36cbe61)</span></li>
<li>klipper/klipper.h <span style="color: grey">(6952b11)</span></li>
<li>klipper/klipper.cpp <span style="color: grey">(798b49f)</span></li>
<li>klipper/klipper.kcfg <span style="color: grey">(a03dd16)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123806/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>