<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123186/">https://git.reviewboard.kde.org/r/123186/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On Март 30th, 2015, 5:01 п.п. UTC, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">From my own experience, autohinting is no "yes or no" question.
=> Should downstream not rather provide global fontconfig snippets that enable autohinting for fonts with (known) crap BC hinting?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sometimes it's still "yes or no". For example, I prefer to turn subpixel rendering and BC off for Liberation Sans (just because I don't want my fonts to be RGB-colored). But I guess most people prefer subpixel rendering and BC for Liberation Sans fonts. BC for LS fonts is a matter of taste.</p></pre>
<br />
<p>- Andrey</p>
<br />
<p>On Март 30th, 2015, 3:42 п.п. UTC, Andrey Bondrov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kde-workspace, Martin Gräßlin and Eike Hein.</div>
<div>By Andrey Bondrov.</div>
<p style="color: grey;"><i>Updated Март 30, 2015, 3:42 п.п.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">We need to add autohint checkbox to KCM fonts, this feature is requested by various users downstream (for example, see https://bugs.mageia.org/show_bug.cgi?id=1240 ).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I patched kde-workspace 4.9 in 2012, now I'd like to submit my patch upstream to have this feature in Plasma 5 for every distribution.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">BTW, LXQt already added autohint option to font settings several monthes ago: https://github.com/lxde/lxqt-config/pull/13#event-187605798</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Old KDE 4 patch was used by ROSA and OpenMandriva since 2012, no issues with it. I had to adjust it a bit to follow Plasma 5 changes but in general it's old well-tested patch. Seems to work fine for me.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcms/fonts/fonts.h <span style="color: grey">(d98bbe2)</span></li>
<li>kcms/fonts/fonts.cpp <span style="color: grey">(9b065e6)</span></li>
<li>kcms/fonts/kxftconfig.h <span style="color: grey">(8e79595)</span></li>
<li>kcms/fonts/kxftconfig.cpp <span style="color: grey">(2cc3a1b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123186/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>