<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119363/">https://git.reviewboard.kde.org/r/119363/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Base Apps, Luigi Toscano and Nicolás Alvarez.</div>
<div>By Marko Käning.</div>
<p style="color: grey;"><i>Updated Feb. 28, 2015, 10:51 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This suggests to upgrade the docbook DTD from 4.2 to 4.5.</p>
<hr style="text-rendering: inherit;margin: 0;padding: 0;white-space: normal;border: 1px solid #ddd;line-height: inherit;" />
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">There is still an open issue here:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Spaces in DATA_INSTALL_DIR need to be handled properly, so that the path in the DTD file</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span style="color: #666666">/</span>Library<span style="color: #666666">/</span>Application<span style="border: 1px solid #FF0000">\</span> Support<span style="color: #666666">/</span>kf5<span style="color: #666666">/</span>kdoctools<span style="color: #666666">/</span>customization<span style="color: #666666">/</span>dtd<span style="color: #666666">/</span>kdex.dtd
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">is correctly set, i.e. using "%20" instead of a space.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Builds/installs fine (if one doesn't use any white-space in DATA_INSTALL_DIR path) </p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>doc/konqueror/index.docbook <span style="color: grey">(a1f8565404be0289b51af37df1687e0911a01fe5)</span></li>
<li>dolphin/docs/index.docbook <span style="color: grey">(5fe85f5d130e3723af556fb02b53970206d1c765)</span></li>
<li>kdepasswd/docs/index.docbook <span style="color: grey">(2ecef470ac8a9384b7aeb16f123f834d040ee375)</span></li>
<li>kfind/docs/index.docbook <span style="color: grey">(d46dfa4138991a356eec32a7043a883150eb81c2)</span></li>
<li>kfind/docs/man-kfind.1.docbook <span style="color: grey">(ef2eb3b9fb1ed1a84ae33fa631b0295a029444e0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119363/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>