<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121831/">https://git.reviewboard.kde.org/r/121831/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 21st, 2015, 2:46 a.m. UTC, <b>Hrvoje Senjan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">can you check what needs to be adjusted in plasma-workspace? it fails to build with your change:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">[ 451s] /home/abuild/rpmbuild/BUILD/plasma-workspace-5.2.90git/libtaskmanager/taskitem.cpp:471:43: error: 'proc->KSysGuard::Process::command' does not have class type
[ 451s] QString cmdline = proc ? proc->command.simplified() : QString(); // proc->command has a trailing space???
[ 451s] ^
[ 451s] /home/abuild/rpmbuild/BUILD/plasma-workspace-5.2.90git/libtaskmanager/taskitem.cpp:501:103: error: no matching function for call to 'KService::KService(<unresolved overloaded function type>, QString&, QString)'
[ 451s] services << QExplicitlySharedDataPointer<KService>(new KService(proc->name, cmdline, QString()));
[ 451s] ^
[ 451s] /home/abuild/rpmbuild/BUILD/plasma-workspace-5.2.90git/libtaskmanager/taskitem.cpp:501:103: note: candidates are:
[ 451s] In file included from /usr/include/KF5/KService/KService:1:0,
[ 451s] from /home/abuild/rpmbuild/BUILD/plasma-workspace-5.2.90git/libtaskmanager/taskitem.cpp:32:
[ 451s] /usr/include/KF5/KService/kservice.h:580:5: note: KService::KService(QDataStream&, int)
[ 451s] KService(QDataStream &str, int offset);
[ 451s] ^
[ 451s] /usr/include/KF5/KService/kservice.h:580:5: note: candidate expects 2 arguments, 3 provided
[ 451s] In file included from /usr/include/KF5/KService/KService:1:0,
[ 451s] from /home/abuild/rpmbuild/BUILD/plasma-workspace-5.2.90git/libtaskmanager/taskitem.cpp:32:
[ 451s] /usr/include/KF5/KService/kservice.h:82:14: note: KService::KService(const KDesktopFile<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">, const QString&)
[ 451s] explicit KService(const KDesktopFile </em>config, const QString &entryPath = QString());
[ 451s] ^
[ 451s] /usr/include/KF5/KService/kservice.h:82:14: note: candidate expects 2 arguments, 3 provided
[ 451s] /usr/include/KF5/KService/kservice.h:75:14: note: KService::KService(const QString&)
[ 451s] explicit KService(const QString &fullpath);
[ 451s] ^
[ 451s] /usr/include/KF5/KService/kservice.h:75:14: note: candidate expects 1 argument, 3 provided
[ 451s] /usr/include/KF5/KService/kservice.h:68:5: note: KService::KService(const QString&, const QString&, const QString&)
[ 451s] KService(const QString &name, const QString &exec, const QString &icon);
[ 451s] ^
[ 451s] /usr/include/KF5/KService/kservice.h:68:5: note: no known conversion for argument 1 from '<unresolved overloaded function type>' to 'const QString&'
[ 451s] /home/abuild/rpmbuild/BUILD/plasma-workspace-5.2.90git/libtaskmanager/taskitem.cpp: In function 'QUrl TaskManager::getServiceLauncherUrl(int, const QString&, const QStringList&)':
[ 451s] /home/abuild/rpmbuild/BUILD/plasma-workspace-5.2.90git/libtaskmanager/taskitem.cpp:516:43: error: 'proc->KSysGuard::Process::command' does not have class type
[ 451s] QString cmdline = proc ? proc->command.simplified() : QString(); // proc->command has a trailing space???
[ 451s] ^</p></pre>
</blockquote>
<p>On February 21st, 2015, 10:46 a.m. UTC, <b>Gregor Mi</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Probably <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">proc->command</code> must be replace with <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">proc->command()</code>. I'll check that.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">How can I find out if which branch was compiled? I assume it is the master branch.</p></pre>
<br />
<p>- Gregor</p>
<br />
<p>On February 20th, 2015, 9:46 p.m. UTC, Gregor Mi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Base Apps, Dominik Haumann, Eike Hein, and John Tapsell.</div>
<div>By Gregor Mi.</div>
<p style="color: grey;"><i>Updated Feb. 20, 2015, 9:46 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libksysguard
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is a follow-up to https://git.reviewboard.kde.org/r/121717/:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In process.h there are several public fields which easily trigger BIC changes. This RR introduces a d-ptr.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">(In a separate commit I would add the .reviewboardrc file)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Compiles and runs. Data is still shown; no visible error. Unit tests succeed.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>processui/scripting.h <span style="color: grey">(2445c0ab0d81af3283c0f6e9c5f349a3d70b0de9)</span></li>
<li>processui/scripting.cpp <span style="color: grey">(76291b0ae0a26e486aa81a4ca3976ff4a47cb3c0)</span></li>
<li>processcore/processes_solaris_p.cpp <span style="color: grey">(f054df4b1e762e9cbec1ff8dea78f467b878bee0)</span></li>
<li>processui/ProcessFilter.cpp <span style="color: grey">(ec520593fb67c777d56817f2493d40dc5ade0347)</span></li>
<li>processui/ProcessModel.cpp <span style="color: grey">(53bc041110c9cdb686fef783895104969b661889)</span></li>
<li>processui/ksysguardprocesslist.cpp <span style="color: grey">(4dc142e864d8353ceafc3a6735ffa81e48291420)</span></li>
<li>processcore/processes.cpp <span style="color: grey">(580df8db152040f1ad075430fdce08fe7ad4ae2d)</span></li>
<li>processcore/processes_atop_p.cpp <span style="color: grey">(24c76e3e35f62bd8e9e705ad32cc11cbd3662601)</span></li>
<li>processcore/processes_base_p.h <span style="color: grey">(71b8a9cc6ee14bf7934a0a9d3199b257b5ce1be7)</span></li>
<li>processcore/processes_linux_p.cpp <span style="color: grey">(898d4fa491873fe95a8b32a5c1b85642b2e46ad5)</span></li>
<li>processcore/processes.h <span style="color: grey">(d09c3265333fe7e2702deaa910c5fbe4bc3ac9e6)</span></li>
<li>tests/processtest.cpp <span style="color: grey">(f9b36e9a3a3c2048b51f1d935f8c40de2ad8a9b8)</span></li>
<li>.reviewboardrc <span style="color: grey">(PRE-CREATION)</span></li>
<li>CMakeLists.txt <span style="color: grey">(cefc86f12be684e195bd148641483e9e1734e636)</span></li>
<li>processcore/process.h <span style="color: grey">(b6695c0ed301dc5f0fad8ba847da811f19ebfd9a)</span></li>
<li>processcore/process.cpp <span style="color: grey">(a38b8be71da1a51cb87f636664ebac817b1d20ab)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121831/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>