<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/110083/">https://git.reviewboard.kde.org/r/110083/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been discarded.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kdelibs and KDEPIM-Libraries.</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Jan. 20, 2015, 4:24 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libkfbapi
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">kdepim-libs are needed in the facebook library only to return user info as KABC::Addressee and note as KMime::Message, plus events use KCalCore classes. This patch makes dependency on kdepim-libs optional and disables building the event classes completely in case kdepim-libs was not found.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds correctly here in both cases</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(5aefdcf)</span></li>
<li>LibKFbAPI-KDEPIM.pc.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>LibKFbAPI-KDEPIMConfig.cmake.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>LibKFbAPI.pc.in <span style="color: grey">(af537d1)</span></li>
<li>libkfbapi/CMakeLists.txt <span style="color: grey">(dac62bc)</span></li>
<li>libkfbapi/commentinfo.h <span style="color: grey">(e5578c7)</span></li>
<li>libkfbapi/kdepim-utils.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libkfbapi/kdepim-utils.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>libkfbapi/likeinfo.h <span style="color: grey">(e06052e)</span></li>
<li>libkfbapi/noteinfo.h <span style="color: grey">(2492db1)</span></li>
<li>libkfbapi/noteinfo.cpp <span style="color: grey">(154593d)</span></li>
<li>libkfbapi/notificationinfo.h <span style="color: grey">(a882694)</span></li>
<li>libkfbapi/userinfo.h <span style="color: grey">(ac22a7e)</span></li>
<li>libkfbapi/userinfo.cpp <span style="color: grey">(26c64da)</span></li>
<li>libkfbapi/userinfoparser_p.h <span style="color: grey">(0189a17)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/110083/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>