<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121717/">https://git.reviewboard.kde.org/r/121717/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 10th, 2015, 4:29 p.m. UTC, <b>Dominik Haumann</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/121717/diff/2/?file=337999#file337999line67" style="color: black; font-weight: bold; text-decoration: underline;">processui/timeutil.h</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">67</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="n">i18nc</span><span class="p">(</span><span class="s">"contains a abbreviated time unit: (s)econds"</span><span class="p">,</span> <span class="s">"%1s ago"</span><span class="p">,</span> <span class="n">s_abs</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">No sure, but maybe in some language we need a proper singular / plural handling here, too?</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Same for the other two i18nc calls.</p></pre>
</blockquote>
<p>On January 10th, 2015, 7:36 p.m. UTC, <b>Chusslove Illich</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I would leave it as it is, and wait for a translator to complain. Although the amount is integer, it is represented with a unit, as if it were real-valued. It would also be ugly to convert the other two to plural, as it would take splitting them into multiple submessages.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ok, dropped this issue then, thanks!</p></pre>
<br />
<p>- Dominik</p>
<br />
<p>On January 9th, 2015, 10:25 a.m. UTC, Gregor Mi wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Base Apps and John Tapsell.</div>
<div>By Gregor Mi.</div>
<p style="color: grey;"><i>Updated Jan. 9, 2015, 10:25 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libksysguard
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This will add a new column "Relative Start Time" which shows how much time has elapsed since the process was started.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Some details:
- add new heading with default location between "Shared Memory" and "Command" and not visible by default
- define What's this
- define Tooltip
- define sorting
- add class TimeUtil with methods:
- systemUptimeSeconds
- systemUptimeAbsolute
- secondsToHumanElapsedString (for this one a unit test was added, see chronotest.cpp)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This code reformatting goes in separate commits:
- ProcessModel.cpp: reformat code: consistent number of linebreaks between method definitions (1 blank line)
- ProcessModel.h: reformat code: split long enum line into separte lines for better diffing</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Side note on sorting:
I was wondering if the sorting of the PID column is exactly the same as with the new "Relative Start Time" column. When testing on my computer it was. But according to this post one cannot generally assume that sorting by PID will reflect the relative start order of the processes: http://stackoverflow.com/questions/822797/about-the-pid-of-the-process</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Run ksysguard, show new column, sort in both directions.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Minor issue: as the seconds pass the values in the new column will not be updated automatically unless there is some user interaction (like mouse hovering/moving or sorting).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">New unit test passes.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>processcore/process.h <span style="color: grey">(85a3a13388c44f768040dbc6602ab3211edd5b21)</span></li>
<li>processui/ksysguardprocesslist.cpp <span style="color: grey">(894e9a4d42112e01e742f1b0a2bcd6be7a844258)</span></li>
<li>processui/timeutil.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(0fb3ab620564abf09f82d1609fc464d5597b2bd3)</span></li>
<li>tests/chronotest.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/chronotest.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>processcore/process.cpp <span style="color: grey">(190f4902fa6f3bae2d8b60dbf1a43be71beb1820)</span></li>
<li>processcore/processes_linux_p.cpp <span style="color: grey">(0cff0e8b407a087dc29f755b12ea3d784ba34e6a)</span></li>
<li>processui/ProcessModel.h <span style="color: grey">(a338536023f9d003a44bcb8420b9288f8673ea92)</span></li>
<li>processui/ProcessModel.cpp <span style="color: grey">(3acf52b92f4a8ca054d88aad1ec6b31f4a31f297)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121717/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>