<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120839/">https://git.reviewboard.kde.org/r/120839/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On Oktober 29th, 2014, 12:02 nachm. UTC, <b>Helio Castro</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ok, way better than the previous one :-)</p></pre>
</blockquote>
<p>On Oktober 29th, 2014, 1:24 nachm. UTC, <b>Frank Schütte</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thanks for your approval. Now who is going to commit my patch? I don't have write access to the repository, as far as I know.</p></pre>
</blockquote>
<p>On Oktober 29th, 2014, 1:32 nachm. UTC, <b>Christoph Feck</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">me. I am just not sure to which branch. When I commit to master, it will only available in 5.x releases.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Does anyone think it should be in 4.14.3 release?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I don't use automounting, but since enbaling automount of unknown devices currently breaks <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">all</em> automounting, I'd say this should be fixed in KDE 4 as well.</p></pre>
<br />
<p>- Thomas</p>
<br />
<p>On Oktober 28th, 2014, 11:37 nachm. UTC, Frank Schütte wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kdelibs, Solid, Christoph Feck, and Helio Castro.</div>
<div>By Frank Schütte.</div>
<p style="color: grey;"><i>Updated Okt. 28, 2014, 11:37 nachm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=243046">243046</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=261376">261376</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-runtime
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hi Christoph,
solid-device-automounter fails to automount unknown devices, even if it is checked,
because in kded/DeviceAutomounter.cpp it fails to evaluate shouldAutomountDevice.
So this patch corrects the logic to at first evaluate shouldAutomountDevice.
Inside this evaluation automountUnknownDevices is evaluated correctly.
Please review this patch. Christoph Feck urged me to submit this patch.
It took me quite a while to figure it out, though.
Bye,
Frank</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>solid-device-automounter/kded/DeviceAutomounter.cpp <span style="color: grey">(14b4e87)</span></li>
<li>solid-device-automounter/lib/AutomounterSettings.cpp <span style="color: grey">(2b3e6be)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120839/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>