<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/103815/">https://git.reviewboard.kde.org/r/103815/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What happened to this? It stalled because of the request for adding a unittest? The unittest framework is in place, so this should be very easy...</p></pre>
<br />
<p>- David Faure</p>
<br />
<p>On January 28th, 2012, 8:39 p.m. UTC, Laszlo Papp wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kdelibs and David Faure.</div>
<div>By Laszlo Papp.</div>
<p style="color: grey;"><i>Updated Jan. 28, 2012, 8:39 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The patch addresses the current issue, for instance with QML-based KDE UIs.
There is no clean way currently for having, for example a Settings page for a
KDE Mobile application, and interact with the backend (generated code)
directly from the QML bits.
The current workaround is to have proxy methods in a helper class that are
properly exposed to QML. There are no visible drawbacks for this extension as
far as a programmer might wanna expose it on wish. :)
The patch has a minor "drawback" because it puts the "static" keyword in line
with the rest of the method declaration, so resides the Q_INVOKABLE macro. It
is not any source or binary incompatible change though, just generated code-style
internals. The patch is simpler and cleaner this way, and I personally prefer
the not split declaration as well. Although this is behind the main point of
the addition, thus can be altered, if needed.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested and works properly on Archlinux (build- and runtime). The Q_INVOKABLE
accessor and mutator methods are properly generated. That said, it is being
planned against the "frameworks" branch since no new features involved in the
KDE4.X series anymore.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdecore/kconfig_compiler/README.dox <span style="color: grey">(b9606f1)</span></li>
<li>kdecore/kconfig_compiler/kconfig_compiler.cpp <span style="color: grey">(4203d30)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/103815/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>