<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118313/">https://git.reviewboard.kde.org/r/118313/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Obsoleted by https://git.reviewboard.kde.org/r/120650/ (and by changes made meanwhile in libkonq).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sorry about this - between the todos, the unittest failures, and the evolving underlying code base, this fell through.</p></pre>
<br />
<p>- David Faure</p>
<br />
<p>On June 17th, 2014, 4 p.m. UTC, Emmanuel Pescosta wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Base Apps and David Faure.</div>
<div>By Emmanuel Pescosta.</div>
<p style="color: grey;"><i>Updated June 17, 2014, 4 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ported Konqlib from KUrl to QUrl (convert-kurl.pl)
Still some ToDos left in the code (I'll mark it inline)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tests fail
konqmimedatatest: (todos)
FAIL! : KonqMimeDataTest::testPopulate() 'mimeData->hasUrls()' returned FALSE.
FAIL! : KonqMimeDataTest::testCut() 'mimeData->hasUrls()' returned FALSE.
konqpopupmenutest: (local setup problem maybe?!)
QFATAL : KonqPopupMenuTest::testFile() ASSERT failure in KServiceTypeFactory::KServiceTypeFactory()
favicontest: (local setup problem maybe?!)
QFATAL : FavIconTest::testSetIconForURL() ASSERT failure in KServiceTypeFactory::KServiceTypeFactory()</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>lib/konq/favicons/favicons.h <span style="color: grey">(30f0272)</span></li>
<li>lib/konq/favicons/favicons.cpp <span style="color: grey">(4646fa5)</span></li>
<li>lib/konq/konq_copytomenu.h <span style="color: grey">(0958e20)</span></li>
<li>lib/konq/konq_copytomenu.cpp <span style="color: grey">(7ee5131)</span></li>
<li>lib/konq/konq_copytomenu_p.h <span style="color: grey">(eb6649a)</span></li>
<li>lib/konq/konq_dndpopupmenuplugin.h <span style="color: grey">(2417080)</span></li>
<li>lib/konq/konq_historyentry.h <span style="color: grey">(6b33b98)</span></li>
<li>lib/konq/konq_historyentry.cpp <span style="color: grey">(bfc4a5d)</span></li>
<li>lib/konq/konq_historyprovider.h <span style="color: grey">(91b5b87)</span></li>
<li>lib/konq/konq_historyprovider.cpp <span style="color: grey">(10a5e74)</span></li>
<li>lib/konq/konq_nameandurlinputdialog.h <span style="color: grey">(3a943f7)</span></li>
<li>lib/konq/konq_nameandurlinputdialog.cpp <span style="color: grey">(2fb06f9)</span></li>
<li>lib/konq/konq_operations.h <span style="color: grey">(b51fa3f)</span></li>
<li>lib/konq/konq_operations.cpp <span style="color: grey">(0cbff08)</span></li>
<li>lib/konq/konq_popupmenu.h <span style="color: grey">(b5f5e39)</span></li>
<li>lib/konq/konq_popupmenu.cpp <span style="color: grey">(caa37e7)</span></li>
<li>lib/konq/konq_popupmenuinformation.h <span style="color: grey">(1454073)</span></li>
<li>lib/konq/konq_popupmenuinformation.cpp <span style="color: grey">(6e1033b)</span></li>
<li>lib/konq/konq_sound.h <span style="color: grey">(8063073)</span></li>
<li>lib/konq/konq_sound.cc <span style="color: grey">(f8a80a9)</span></li>
<li>lib/konq/konqmimedata.h <span style="color: grey">(a2640a2)</span></li>
<li>lib/konq/konqmimedata.cpp <span style="color: grey">(8f9ecf1)</span></li>
<li>lib/konq/tests/favicontest.cpp <span style="color: grey">(d48b03d)</span></li>
<li>lib/konq/tests/konqmimedatatest.cpp <span style="color: grey">(6a2be4f)</span></li>
<li>lib/konq/tests/konqpopupmenutest.cpp <span style="color: grey">(46851c5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118313/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>