<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120287/">https://git.reviewboard.kde.org/r/120287/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Software on Mac OS X and kde-workspace.</div>
<div>By René J.V. Bertin.</div>
<p style="color: grey;"><i>Updated Oct. 14, 2014, 6:06 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A new revision of the patchset.
This revision includes the plasma subdirectory in the build, in order to provide the possibility to run plasmoids via plasma-windowed.
In an initial step, te CMake files under /plasma have been changed to exclude the same components on OS X as on MS Windows, i.e. checks are now for `NOT WIN32 AND NOT APPLE` instead of for `NOT WIN32` only. Further exclusions were then made for the components that gave build errors due to X11 dependencies.
Plasma-windowed's build process was modified to add an Info.plist that makes the application an agent, i.e. a GUI application without menubar or presence in the Dock or AppSwitcher.
Changes had to be made to the plasma-windowed code to prevent crashing when exiting from a successfully loaded plasmoid through the standard Command-Q quit instead of by closing the window. Replacing all `delete` operations of QObject-derived class instances with `->deleteLater()` was enough to prevent crashing (suggesting that a nested eventloop was the culprit, or at the least an immediate delete rather than a deferred delete compatible with Objective-C's `release` (which takes effect when exitting the event-loop in which the release was done)).
I tried making PlasmaApp inherit KApplication instead of KUniqueApplication so that multiple instances can be run concurrently. This has the effect that plasmoids that usually work are no longer rendered.
I'd appreciate pointers on how to circumvent this.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">A few rather straightforward patches to make the relevant bits of KDE4's kde-workspace build and function on OS X.
The main interest is having the systemsettings control panel to control the various relevant KDE settings among which desktop search, fonts, colours and even style.
The oxygen style builds and looks good but shows some updating glitches due to compositing.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm submitting this patch partly in hope it may be useful in bringing kf5-workspace to OS X, one day.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">On OS X 10.6.8 and 10.9.4 with KDE/MacPorts (4.12.5 and more recently kdelibs git/master, 4.14.1).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(df8a1f7)</span></li>
<li>kcontrol/CMakeLists.txt <span style="color: grey">(fc666b1)</span></li>
<li>kcontrol/krdb/krdb.cpp <span style="color: grey">(36fc99c)</span></li>
<li>kcontrol/style/CMakeLists.txt <span style="color: grey">(d832b20)</span></li>
<li>libs/CMakeLists.txt <span style="color: grey">(c0576fe)</span></li>
<li>plasma/CMakeLists.txt <span style="color: grey">(199dbb0)</span></li>
<li>plasma/generic/shells/plasma-windowed/plasmaapp.cpp <span style="color: grey">(dbdff47)</span></li>
<li>plasma/netbook/CMakeLists.txt <span style="color: grey">(1eff685)</span></li>
<li>plasma/netbook/containments/CMakeLists.txt <span style="color: grey">(c96a688)</span></li>
<li>plasma/desktop/CMakeLists.txt <span style="color: grey">(2de78dd)</span></li>
<li>plasma/desktop/applets/CMakeLists.txt <span style="color: grey">(6f80cec)</span></li>
<li>plasma/generic/CMakeLists.txt <span style="color: grey">(cfaf14f)</span></li>
<li>plasma/generic/applets/CMakeLists.txt <span style="color: grey">(2b888ee)</span></li>
<li>plasma/generic/dataengines/CMakeLists.txt <span style="color: grey">(d240683)</span></li>
<li>plasma/generic/runners/CMakeLists.txt <span style="color: grey">(6831ac0)</span></li>
<li>plasma/generic/shells/plasma-windowed/CMakeLists.txt <span style="color: grey">(86b7770)</span></li>
<li>plasma/generic/shells/plasma-windowed/Info.plist.template <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120287/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/09/20/b212730f-6258-4277-851c-226bc0673aa1__patchreview-20140920.patch">copy of the diff file saved locally, which had no tabs when I uploaded it. Checksum: 3989cdd46af3c891e570974d66c330403dcd41c4ee5e17a372fa385080cbabd1 </a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>