<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120554/">https://git.reviewboard.kde.org/r/120554/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kdelibs and Vavelin Kevin.</div>
<div>By Jeremy Whiting.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kompare
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I spent a bit of time porting kompare to kf5. It builds and runs and compares files and folders but I'm pretty sure I missed something. </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'll reread my changes also but wanted to get this out there to be played with also.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It builds, runs and seems to wok ok comparing files and folders. The QFileDialog it uses wasn't showing files I expected to see though, may need to play with the filters etc.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>komparepart/kompareconnectwidget.cpp <span style="color: grey">(2a8cb92)</span></li>
<li>komparepart/komparelistview.cpp <span style="color: grey">(b2935c9)</span></li>
<li>komparepart/kompareprefdlg.cpp <span style="color: grey">(0b18696)</span></li>
<li>komparepart/komparesaveoptionswidget.h <span style="color: grey">(9c49815)</span></li>
<li>kompare_shell.cpp <span style="color: grey">(9d22085)</span></li>
<li>komparenavtreepart/CMakeLists.txt <span style="color: grey">(da52bc7)</span></li>
<li>komparenavtreepart/komparenavtreepart.h <span style="color: grey">(eb08329)</span></li>
<li>komparenavtreepart/komparenavtreepart.cpp <span style="color: grey">(d3bdc93)</span></li>
<li>CMakeLists.txt <span style="color: grey">(86e4504)</span></li>
<li>doc/CMakeLists.txt <span style="color: grey">(06d8987)</span></li>
<li>interfaces/CMakeLists.txt <span style="color: grey">(4bb0c6c)</span></li>
<li>interfaces/kompareinterface.h <span style="color: grey">(a28d209)</span></li>
<li>kompare_shell.h <span style="color: grey">(de099ff)</span></li>
<li>komparepart/CMakeLists.txt <span style="color: grey">(ee83458)</span></li>
<li>komparepart/kompare_part.h <span style="color: grey">(0c4d3dd)</span></li>
<li>komparepart/kompare_part.cpp <span style="color: grey">(08df1dc)</span></li>
<li>komparepart/kompareconnectwidget.h <span style="color: grey">(03eb746)</span></li>
<li>pics/sc-apps-kompare.svgz <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/hi22-app-kompare.png <span style="color: grey">(053b1690571a7b15af10970aff33d39365b9851d)</span></li>
<li>pics/hi32-app-kompare.png <span style="color: grey">(1dd3577e8d68a53662b20bb28349bde273a840c8)</span></li>
<li>pics/hi48-app-kompare.png <span style="color: grey">(8eda48e1ada22126a1284b968a4c557d557c949b)</span></li>
<li>pics/hisc-app-kompare.svgz <span style="color: grey">(945a66312154ef501013693bd56cf6d454490869)</span></li>
<li>main.cpp <span style="color: grey">(ac68e24)</span></li>
<li>pics/128-apps-kompare.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/16-apps-kompare.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/22-apps-kompare.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/32-apps-kompare.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/48-apps-kompare.png <span style="color: grey">(PRE-CREATION)</span></li>
<li>pics/CMakeLists.txt <span style="color: grey">(512f6e8)</span></li>
<li>pics/hi128-app-kompare.png <span style="color: grey">(ffcd33d50499ac8fb02fe9c5097840f5787f35dd)</span></li>
<li>pics/hi16-app-kompare.png <span style="color: grey">(c70d54397626bf5d072bb8271076916f43126213)</span></li>
<li>komparepart/komparesaveoptionswidget.cpp <span style="color: grey">(06530d8)</span></li>
<li>komparepart/komparesplitter.h <span style="color: grey">(11a344f)</span></li>
<li>komparepart/komparesplitter.cpp <span style="color: grey">(2848f88)</span></li>
<li>komparepart/kompareview.h <span style="color: grey">(93ea064)</span></li>
<li>kompareurldialog.cpp <span style="color: grey">(561dd45)</span></li>
<li>libdialogpages/CMakeLists.txt <span style="color: grey">(2290665)</span></li>
<li>libdialogpages/diffpage.cpp <span style="color: grey">(94221ca)</span></li>
<li>libdialogpages/filespage.cpp <span style="color: grey">(417fbd1)</span></li>
<li>libdialogpages/filessettings.h <span style="color: grey">(dc3306e)</span></li>
<li>libdialogpages/pagebase.h <span style="color: grey">(0cef46f)</span></li>
<li>libdialogpages/pagebase.cpp <span style="color: grey">(4aa33d7)</span></li>
<li>libdialogpages/viewpage.cpp <span style="color: grey">(e26d728)</span></li>
<li>libdialogpages/viewsettings.h <span style="color: grey">(305e934)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120554/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>