<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119363/">https://git.reviewboard.kde.org/r/119363/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 23rd, 2014, 9:26 a.m. PDT, <b>Scarlett Clark</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I had to use this patch to get the frameworks branch to build while packaging for Kubuntu. Anyway we can get this pushed to at least frameworks branch?</p></pre>
</blockquote>
<p>On August 24th, 2014, 8:59 a.m. PDT, <b>Marko Käning</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I suggested the commit to frameworks to Luigi back then, but he had some arguments against it at the time.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Let's see what he thinks now, as I don't want to override him there.</p></pre>
</blockquote>
<p>On August 24th, 2014, 9:09 a.m. PDT, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I don't find the discussion but I think I wrote something on the line of: let's see if it can be made working without this, because, if kdelibs4support is installed, this should work. Scarlett, can you please confirm that it does not compile even if kdelibs4support is installed in the buildroot? Could you please paste the error?</p></pre>
</blockquote>
<p>On August 24th, 2014, 9:11 a.m. PDT, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">To be clear: I'm not against pushing this, you can commit it if no other solutions works and it's the expected step anyway for a complete porting (without kdelibs4support). My point is that the backward compatibility should work; if not, I spent quite some time working on nothing.</p></pre>
</blockquote>
<p>On August 25th, 2014, 10:12 a.m. PDT, <b>Scarlett Clark</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">http://goo.gl/mLRi02 I pasted my build depends and my failed build.</p></pre>
</blockquote>
<p>On September 4th, 2014, 2:35 p.m. PDT, <b>Luigi Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sotty, I totally missed this comment! I think you miss kdelibs4support in the build dependencies; with that package installed, compilation should work.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I already spoke to you today, but I just confirmed libkf5kdelibs4support-dev (>= 5.1.0) is in the build depends.</p></pre>
<br />
<p>- Scarlett</p>
<br />
<p>On August 24th, 2014, 9:33 a.m. PDT, Marko Käning wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Base Apps, Luigi Toscano and Nicolás Alvarez.</div>
<div>By Marko Käning.</div>
<p style="color: grey;"><i>Updated Aug. 24, 2014, 9:33 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This suggests to upgrade the docbook DTD from 4.2 to 4.5.</p>
<hr style="text-rendering: inherit;margin: 0;padding: 0;white-space: normal;border: 1px solid #ddd;line-height: inherit;" />
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">There is still an open issue here:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Spaces in DATA_INSTALL_DIR need to be handled properly, so that the path in the DTD file</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span style="color: #666666">/</span>Library<span style="color: #666666">/</span>Application<span style="border: 1px solid #FF0000">\</span> Support<span style="color: #666666">/</span>kf5<span style="color: #666666">/</span>kdoctools<span style="color: #666666">/</span>customization<span style="color: #666666">/</span>dtd<span style="color: #666666">/</span>kdex.dtd
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">is correctly set, i.e. using "%20" instead of a space.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Builds/installs fine (if one doesn't use any white-space in DATA_INSTALL_DIR path) </p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>doc/konqueror/index.docbook <span style="color: grey">(a1f8565404be0289b51af37df1687e0911a01fe5)</span></li>
<li>dolphin/docs/index.docbook <span style="color: grey">(5fe85f5d130e3723af556fb02b53970206d1c765)</span></li>
<li>kdepasswd/docs/index.docbook <span style="color: grey">(2ecef470ac8a9384b7aeb16f123f834d040ee375)</span></li>
<li>kfind/docs/index.docbook <span style="color: grey">(d46dfa4138991a356eec32a7043a883150eb81c2)</span></li>
<li>kfind/docs/man-kfind.1.docbook <span style="color: grey">(ef2eb3b9fb1ed1a84ae33fa631b0295a029444e0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119363/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>