<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120078/">https://git.reviewboard.kde.org/r/120078/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">[ 22%] Building CXX object src/CMakeFiles/KF5XmlGui.dir/kmainwindow.cpp.o <br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
/home/ltinkl/git/plasma-next-setup-script/kxmlgui/src/kmainwindow.cpp: In member function ‘virtual void KMainWindow::applyMainWindowSettings(const KConfigGroup&)’:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
/home/ltinkl/git/plasma-next-setup-script/kxmlgui/src/kmainwindow.cpp:616:30: error: invalid use of incomplete type ‘class QWindow’<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
resize(windowHandle()->size());<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
^<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
In file included from /usr/include/qt5/QtWidgets/qwidget.h:45:0,<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
from /usr/include/qt5/QtWidgets/qmainwindow.h:45,<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
from /usr/include/qt5/QtWidgets/QMainWindow:1,<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
from /home/ltinkl/git/plasma-next-setup-script/kxmlgui/src/kmainwindow.h:34,<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
from /home/ltinkl/git/plasma-next-setup-script/kxmlgui/src/kmainwindow.cpp:27:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
/usr/include/qt5/QtGui/qwindowdefs.h:56:7: error: forward declaration of ‘class QWindow’<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
class QWindow;<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
^<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
In file included from /home/ltinkl/git/plasma-next-setup-script/kxmlgui/src/kmainwindow.cpp:890:0:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
/home/ltinkl/git/plasma-next-setup-script/kxmlgui/build/src/moc_kmainwindow.cpp: In static member function ‘static void KMainWindow::qt_static_metacall(QObject<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">, QMetaObject::Call, int, void<strong style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">)’:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
/home/ltinkl/git/plasma-next-setup-script/kxmlgui/build/src/moc_kmainwindow.cpp:110:42: warning: ‘virtual void KMainWindow::showAboutApplication()’ is deprecated (declared at /home/ltinkl/git/plasma-next-setup-script/kxmlgui/src/kmainwindow.h:604) [-Wdeprecated-declarations]<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
case 5: _t->showAboutApplication(); break;<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
^<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
make[2]: <strong style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"><em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"> [src/CMakeFiles/KF5XmlGui.dir/kmainwindow.cpp.o] Error 1<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
make[1]: </em></strong> [src/CMakeFiles/KF5XmlGui.dir/all] Error 2<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
make: </strong></em> [all] Error 2</p></pre>
<br />
<p>- Lukáš Tinkl</p>
<br />
<p>On září 6th, 2014, 11:09 dop. CEST, Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated Zář. 6, 2014, 11:09 dop.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=337353">337353</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kxmlgui
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
a) ensures there's windowaHandle() to restore the size for<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
b) works around a pending Qt bug by explicitly coyping the restored QWindow size to the QWidget size</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">also see https://git.reviewboard.kde.org/r/119594/</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hrvoje, see bug - not tested myself.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kmainwindow.cpp <span style="color: grey">(e273a76)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120078/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>