<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119701/">https://git.reviewboard.kde.org/r/119701/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Dolphin and KDE Base Apps.</div>
<div>By Mathieu Tarral.</div>
<p style="color: grey;"><i>Updated Aug. 14, 2014, 4:12 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fixes display issues of dolphin statusbar widgets when a high DPI value is used (>= 196 for example).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Changes :<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
- remove setFixedHeight to fix vertical alignement<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
- changes fixed values in setMaximumWidth from 150 to averageCharWidth of m_label * 15</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So, the font width now respects the dpi settings because averageCharWidth will get it's value.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
But there is still an hardcoded value (15).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Note : QtCurve seemed to be bugged (see screenshots)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">set DPI to 196 (System Settings -> Appearance -> Fonts)<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
run dolphin<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
look at widgets width in statusbar</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>dolphin/src/statusbar/dolphinstatusbar.cpp <span style="color: grey">(169395e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119701/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/08/10/858ff768-864d-4adf-9824-e38e82c7cf66__show-bug.png">show-bug</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/08/10/e8484513-446d-4805-b1e8-1315b54f98f3__cleanlooks.png">fix-cleanlooks</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/08/10/7bc31f0b-fe7b-4ed2-8d53-ca00a994e70a__oxygen.png">fix-oxygen</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/08/10/ecf5d4db-4b60-411a-8da9-40d143d9a0e0__plastique.png">fix-plastique</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/08/10/599d0de4-f85b-46f1-a33a-465837cdbe78__qtcurve-agua.png">fix-qtcurve-agua</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/08/10/0daa1663-db15-4797-9ba7-1a0d0e471d7f__qtcurve-breeze.png">fix-qcurve-breeze</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/08/10/ae97cb7b-2d6b-493d-bba1-4a083e5f7ad7__qtcurve-default.png">fix-qtcurve-default</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>