<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119454/">https://git.reviewboard.kde.org/r/119454/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kdelibs, Scott Kitterman, Luca Beltrame, and Andrea Scarpino.</div>
<div>By Raphael Kubo da Costa.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=327633">327633</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Since PyQt 4.10, PyQt.pyqtconfig is deprecated and not available unless<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
PyQt is built using the old configure script.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">PyKDE4 itself has recently been adjusted to mimic PyQt itself and only<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
install its pykdeconfig module if pyqtconfig is present. Additionally,<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
information such as SIP flags and the directory where PyKDE's SIP files<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
are installed are now also provided in the<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
PyKDE4.kdecore.PYKDE_CONFIGURATION dict.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This commit completely rewrites FindPyKDE4.py to make it look like<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
FindPyQt.cmake after commit a7e4743: most of the information used by<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
FindPyKDE4.cmake is fetched from PyKDE4.kdecore, and we first try to<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
obtain the SIP flags and directory from pykdeconfig and, if it fails, we<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
use PYKDE_CONFIGURATION.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Furthermore, FindPyKDE4.py now only prints the variables that are<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
actually consumed by FindPyKDE4.cmake -- it is not possible to obtain<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
all the data provided by pykdeconfig in PYKDE_CONFIGURATION. We've also<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
stopped reading and setting PYKDE4_VERSION_TAG, since PyKDE4 stopped<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
setting a KDE tag in 2008 (and its value was 3_92_0 at the time).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Modules such as Kate's Pate plugin detects and builds fine without pyqtconfig and pykdeconfig on the system.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/modules/FindPyKDE4.cmake <span style="color: grey">(98f7c37477393731152d2d8fd51fc50cb9bbd9ef)</span></li>
<li>cmake/modules/FindPyKDE4.py <span style="color: grey">(e436c2a907efe5e8f764e14ed921d3a87d413f34)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119454/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>