<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119280/">https://git.reviewboard.kde.org/r/119280/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for kdelibs and David Faure.</div>
<div>By Eike Hein.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As discussed, this adds the Web Shortcuts KCM, formerly shipped as part as Konqueror, to the KIO framework, where the URI Filters framework it configures resides as well. This makes more sense than stuffing it into workspace, since Web Shortcuts have many app level downstreams (e.g. Konversation, Okular and Konsole) which try to run the KCM via kcmshell5, and may not be running inside Plasma Desktop at the time.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I've lightly modified the code to make it build, and made the naming more consistent - "webshortcuts" is now used throughout where previously was a mix of "ebrowsing" and "kurifilt". This does also mean the .po name changed, but the KCM only contains a single string.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm the least confident on the CMake stuff, especially the TRANSLATION_DOMAIN redefinition, so I'd be happy for review.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kcms/webshortcuts/main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kcms/webshortcuts/webshortcuts.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/urifilters/ikws/CMakeLists.txt <span style="color: grey">(4efe24e)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(6f8373f)</span></li>
<li>src/kcms/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kcms/webshortcuts/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kcms/webshortcuts/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/kcms/webshortcuts/main.h <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119280/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>