<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118851/">https://git.reviewboard.kde.org/r/118851/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/118851/diff/2/?file=282692#file282692line23" style="color: black; font-weight: bold; text-decoration: underline;">CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">20</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">find_package</span><span class="p">(</span><span class="s">KF5</span> <span class="s">REQUIRED</span> <span class="s">Archive</span> <span class="s">Bookmarks</span> <span class="s">CoreAddons</span> <span class="s">Config</span> <span class="s">ConfigWidgets</span> <span class="s">DBusAddons</span> <span class="s">KIO</span> <span class="s">KDELibs4Support</span> <span class="s">Parts</span> <span class="s">Su</span> <span class="s">Activities</span><span class="p">)</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">23</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="nb">find_package</span><span class="p">(</span><span class="s">KF5</span><span class="hl"> </span><span class="o"><span class="hl">${</span></span><span class="nv"><span class="hl">KF5_VERSION</span></span><span class="o"><span class="hl">}</span></span> <span class="s">REQUIRED</span> <span class="s">Archive</span> <span class="s">Bookmarks</span> <span class="s">CoreAddons</span> <span class="s">Config</span> <span class="s">ConfigWidgets</span> <span class="s">DBusAddons</span> <span class="s">KIO</span> <span class="s">KDELibs4Support</span> <span class="s">Parts</span> <span class="s">Su</span> <span class="s">Activities</span><span class="p">)</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">But now you'll want to put an actual version number in here (or remove the variable use altogether).</pre>
</div>
<br />
<p>- Alex Merry</p>
<br />
<p>On June 20th, 2014, 6:44 p.m. UTC, Scarlett Clark wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Dolphin, KDE Base Apps, Plasma, and Jonathan Riddell.</div>
<div>By Scarlett Clark.</div>
<p style="color: grey;"><i>Updated June 20, 2014, 6:44 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I was ending up with so.SOVERSION when building this, so through some research I have come up with this patch to correct the issue.
If there is a better way, please let me know.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Builds fine on Kubuntu Utopic frameworks chroot. Results in the expected:
libdolphinprivate.so
libdolphinprivate.so.4.97.0
libdolphinprivate.so.5
libkdeinit5_dolphin.so
libkonq.so
libkonq.so.4.97.0
libkonq.so.5
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(a5588ea)</span></li>
<li>dolphin/src/CMakeLists.txt <span style="color: grey">(ce629fb)</span></li>
<li>lib/konq/CMakeLists.txt <span style="color: grey">(6857e19)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118851/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>