<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118313/">https://git.reviewboard.kde.org/r/118313/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 25th, 2014, 1:31 p.m. UTC, <b>Emmanuel Pescosta</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/118313/diff/1/?file=274782#file274782line192" style="color: black; font-weight: bold; text-decoration: underline;">lib/konq/konq_popupmenu.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void KonqPopupMenuPrivate::init(KonqPopupMenu::Flags kpf, KParts::BrowserExtension::PopupFlags flags)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">191</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">url</span><span class="p">.</span><span class="n">cleanPath</span><span class="p">();</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">192</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="c1"><span class="hl">//</span>url.cleanPath();<span class="hl"> FIXME KUrl::cleanPath()</span></span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KUrl::cleanPath() -> QUrl::???</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is documented in kurl.h :
url.setPath(QDir::cleanPath(url.path()))
(with some caveats, but that's the best we can do I think)</pre>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 25th, 2014, 1:31 p.m. UTC, <b>Emmanuel Pescosta</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/118313/diff/1/?file=274788#file274788line30" style="color: black; font-weight: bold; text-decoration: underline;">lib/konq/konqmimedata.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">30</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">kdeURLs</span><span class="p">.</span><span class="n">populateMimeData</span><span class="p">(</span><span class="n">mimeData</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">30</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cm"> kdeURLs.populateMimeData(mimeData);<span class="hl"> // FIXME</span></span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is "mimeData->setUrls(kdeUrls);" correct?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Documented in kurl.h too (in the documentation for populateMimeData)
* @deprecated since 5.0, use QMimeData::setUrls, followed by KUrlMimeData::setMetaData if you have metadata.
</pre>
<br />
<p>- David</p>
<br />
<p>On May 25th, 2014, 1:27 p.m. UTC, Emmanuel Pescosta wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Base Apps, KDE Frameworks and David Faure.</div>
<div>By Emmanuel Pescosta.</div>
<p style="color: grey;"><i>Updated May 25, 2014, 1:27 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-baseapps
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ported Konqlib from KUrl to QUrl (convert-kurl.pl)
Still some ToDos left in the code (I'll mark it inline)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tests fail
konqmimedatatest: (todos)
FAIL! : KonqMimeDataTest::testPopulate() 'mimeData->hasUrls()' returned FALSE.
FAIL! : KonqMimeDataTest::testCut() 'mimeData->hasUrls()' returned FALSE.
konqpopupmenutest: (local setup problem maybe?!)
QFATAL : KonqPopupMenuTest::testFile() ASSERT failure in KServiceTypeFactory::KServiceTypeFactory()
favicontest: (local setup problem maybe?!)
QFATAL : FavIconTest::testSetIconForURL() ASSERT failure in KServiceTypeFactory::KServiceTypeFactory()</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>lib/konq/favicons/favicons.h <span style="color: grey">(30f0272)</span></li>
<li>lib/konq/favicons/favicons.cpp <span style="color: grey">(4646fa5)</span></li>
<li>lib/konq/konq_copytomenu.h <span style="color: grey">(0958e20)</span></li>
<li>lib/konq/konq_copytomenu.cpp <span style="color: grey">(7ee5131)</span></li>
<li>lib/konq/konq_copytomenu_p.h <span style="color: grey">(eb6649a)</span></li>
<li>lib/konq/konq_dndpopupmenuplugin.h <span style="color: grey">(2417080)</span></li>
<li>lib/konq/konq_historyentry.h <span style="color: grey">(6b33b98)</span></li>
<li>lib/konq/konq_historyentry.cpp <span style="color: grey">(bfc4a5d)</span></li>
<li>lib/konq/konq_historyprovider.h <span style="color: grey">(91b5b87)</span></li>
<li>lib/konq/konq_historyprovider.cpp <span style="color: grey">(10a5e74)</span></li>
<li>lib/konq/konq_nameandurlinputdialog.h <span style="color: grey">(3a943f7)</span></li>
<li>lib/konq/konq_nameandurlinputdialog.cpp <span style="color: grey">(2fb06f9)</span></li>
<li>lib/konq/konq_operations.h <span style="color: grey">(b51fa3f)</span></li>
<li>lib/konq/konq_operations.cpp <span style="color: grey">(0cbff08)</span></li>
<li>lib/konq/konq_popupmenu.h <span style="color: grey">(b5f5e39)</span></li>
<li>lib/konq/konq_popupmenu.cpp <span style="color: grey">(caa37e7)</span></li>
<li>lib/konq/konq_popupmenuinformation.h <span style="color: grey">(1454073)</span></li>
<li>lib/konq/konq_popupmenuinformation.cpp <span style="color: grey">(6e1033b)</span></li>
<li>lib/konq/konq_sound.h <span style="color: grey">(8063073)</span></li>
<li>lib/konq/konq_sound.cc <span style="color: grey">(f8a80a9)</span></li>
<li>lib/konq/konqmimedata.h <span style="color: grey">(a2640a2)</span></li>
<li>lib/konq/konqmimedata.cpp <span style="color: grey">(8f9ecf1)</span></li>
<li>lib/konq/tests/favicontest.cpp <span style="color: grey">(d48b03d)</span></li>
<li>lib/konq/tests/konqmimedatatest.cpp <span style="color: grey">(6a2be4f)</span></li>
<li>lib/konq/tests/konqpopupmenutest.cpp <span style="color: grey">(46851c5)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118313/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>