<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/103478/">https://git.reviewboard.kde.org/r/103478/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Even if it does not crash, the --waitforwm key is completely broken w/o this patch since the application will wait for some random property forever.
-> No idea what --waitforwm is good for, but either this patch should go in or the option removed.
For testing the application has likely to be run from ~/.kde/env since the standard does not mandate to withdraw it (and kwin doesn't), so it's not a secure check whether a NETWM compliant WM is *still* present at all.
openbox withdraws it, so you could
openbox --replace & sleep 5; pkill openbox; sleep 5; klipper --waitforwm & sleep 30; kwin &
or alternatively just
kquitapp kwin; sleep 1; xprop -remove -root _NET_SUPPORTED; sleep 1; klipper --waitforwm & sleep 30; kwin &
Assuming it would be relevant, you got a shipIt! from at least here - sorry for not reviewing before.</pre>
<br />
<p>- Thomas Lübking</p>
<br />
<p>On May 12th, 2014, 10:25 p.m. UTC, Christoph Feck wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Christoph Feck.</div>
<p style="color: grey;"><i>Updated May 12, 2014, 10:25 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=287364">287364</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">KApplication references atom_NetSupported in parseCommandLine() before it is
initialized. This patch fixes it by reordering the code.
I verified it no longer crashes when invoking with "--waitforwm", but I have no idea how to test if it actually works.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/kernel/kapplication.cpp <span style="color: grey">(cc20f05)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/103478/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>