<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118091/">https://git.reviewboard.kde.org/r/118091/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 12th, 2014, 5:28 a.m. UTC, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">changing the coding style would completely break the already started port to xcb and thus Qt5, see https://git.reviewboard.kde.org/r/114178/</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ah okay I see. Thanks for the quick review though Martin.</pre>
<br />
<p>- Uzair</p>
<br />
<p>On May 12th, 2014, 1:36 a.m. UTC, Uzair Shamim wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Base Apps.</div>
<div>By Uzair Shamim.</div>
<p style="color: grey;"><i>Updated May 12, 2014, 1:36 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ksnapshot
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Certain parts of the code did not follow the kde code guideline and while I know it is not mandatory to follow the guide lines, but I felt I should fix it. There were certain parts I was unsure about so I left them as they were. Most of the changes are just with brace placement.
KDE Coding Standard: http://techbase.kde.org/Policies/Kdelibs_Coding_Style</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiles fine, seems to take screenshots just like before. As I said, 99% of the changes are just brace placement.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kbackgroundsnapshot.cpp <span style="color: grey">(9d81ba1)</span></li>
<li>kipiimagecollectionselector.h <span style="color: grey">(10afedc)</span></li>
<li>kipiimagecollectionselector.cpp <span style="color: grey">(5fe09d8)</span></li>
<li>kipiinterface.h <span style="color: grey">(1c18039)</span></li>
<li>ksnapshot.cpp <span style="color: grey">(0d8e996)</span></li>
<li>ksnapshotimagecollectionshared.cpp <span style="color: grey">(8ef1b0e)</span></li>
<li>ksnapshotinfoshared.cpp <span style="color: grey">(0e0d840)</span></li>
<li>ksnapshotobject.cpp <span style="color: grey">(608f7dc)</span></li>
<li>ksnapshotpreview.cpp <span style="color: grey">(db4fd10)</span></li>
<li>main.cpp <span style="color: grey">(4b4f097)</span></li>
<li>regiongrabber.cpp <span style="color: grey">(fb038a3)</span></li>
<li>snapshottimer.cpp <span style="color: grey">(843f06d)</span></li>
<li>windowgrabber.cpp <span style="color: grey">(21a9531)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118091/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>