<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117044/">https://git.reviewboard.kde.org/r/117044/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 6246e99b43f3d1a9e15d563fbb5e173ed50ba5e5 by Tomáš Trnka to branch KDE/4.13.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On March 25th, 2014, 7:17 a.m. UTC, Tomáš Trnka wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Tomáš Trnka.</div>
<p style="color: grey;"><i>Updated March 25, 2014, 7:17 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Avoid unnecessary automounting in KDiskFreeSpaceInfo::freeSpaceInfo
Previously, all unmounted autofs mountpoints were always mounted
by krunner/plasma-desktop on startup, defeating the purpose of
automounting. Let's ignore the unmounted filesystems instead when
gathering free space stats, just like the "df" utility does.
Everything still gets mounted properly on first real access.
The change itself is pretty trivial and I would regard it as a bugfix
(and thus eligible for 4.13), but I'm posting it for review to see
what you kdelibs people think.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm using this patch on kdelibs since 4.11 and I have noted no problems
in connection with ~4 automounted filesystems.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kio/kfile/kdiskfreespaceinfo.cpp <span style="color: grey">(f11eb0998f0e718e9b366f8c26da30586bfa44ef)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117044/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>