<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117091/">https://git.reviewboard.kde.org/r/117091/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On April 23rd, 2014, 7:41 a.m. CEST, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is that only relevant for the legacy (XSS) locker or also for the new locker? I'm just wondering whether it needs to be ported to master</pre>
</blockquote>
<p>On April 23rd, 2014, 3:11 p.m. CEST, <b>Wolfgang Bauer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes. I just tried, and the screen locker in master does have the same problem.
I wasn't able yet to get powerdevil working with plasma next, but when I call the Lock() method via DBUS while the locker is already running and still in the grace period (I manually created a ~/.config/kscreensaverrc for that), the password input field is missing there as well, so you cannot unlock.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have adapted the patch to master as well:
https://build.opensuse.org/package/view_file/home:wolfi323:branches:KDE:Unstable:Frameworks/plasma-workspace5/screenlocker-always-show-password-dialog-when-needed.patch?expand=0
I tested it and it fixes the problem there too.
Should I create a new review request for this? There are no drastic differences to the KDE4 patch anyway.</pre>
<br />
<p>- Wolfgang</p>
<br />
<p>On April 22nd, 2014, 10:34 p.m. CEST, Wolfgang Bauer wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kde-workspace, Plasma and Aaron J. Seigo.</div>
<div>By Wolfgang Bauer.</div>
<p style="color: grey;"><i>Updated April 22, 2014, 10:34 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=327947">327947</a>,
<a href="http://bugs.kde.org/show_bug.cgi?id=329076">329076</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If the screen locker is set to not require a password to unlock, it will not show the password input field even when the powermanagement settings suspend the system and are set to require a password after resume (when it was already running at that point).
This locks people out of their system.
This patch adds a signal handler for SIGUSR1 that switches the running greeter to immediateLock mode. The locker sends that signal to make sure the greeter shows the password input field when necessary.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Disable "Require password after" in the screen locker settings (the default), set it to start after 1 min. (for easier testing).
Enable "Suspend session after" and set it to 2 minutes. (set the action to "Suspend", "Hibernate", or "Lock Screen", doesn't matter)
Make sure "Lock screen on resume" is enabled in the powermanagements "Advanced Options" (it is by default).
After 1 minute the screen locker kicks in, and doesn't require a password.
After 2 minutes the session gets suspended, hibernated or locked, and requires a password to resume.
Without this patch no password dialog is shown, the user cannot resume the session by entering the password.
With this patch this works: there is a password input field, the session is unlocked when the user enters the password.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksmserver/screenlocker/greeter/greeterapp.cpp <span style="color: grey">(c5e2f85)</span></li>
<li>ksmserver/screenlocker/greeter/main.cpp <span style="color: grey">(d898734)</span></li>
<li>ksmserver/screenlocker/greeter/greeterapp.h <span style="color: grey">(8b79188)</span></li>
<li>ksmserver/screenlocker/ksldapp.cpp <span style="color: grey">(3dfcc9e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117091/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>