<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117400/">https://git.reviewboard.kde.org/r/117400/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kde-workspace and Oswald Buddenhagen.</div>
<div>By David Faure.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">kdm: read DesktopNames from session file and export XDG_CURRENT_DESKTOP from it
[after converting ';' (XDG list separator) to ':' (path separator)]
As discussed at the freedesktop summit.
XDG_CURRENT_DESKTOP is useful for OnlyShowIn and for the new mimeapps.list spec.
+ Add DesktopNames key to kdm sessions files (separate commit).
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Rebuilt OpenSuSE's kdm with the patch applied, commented out the setting of XDG_CURRENT_DESKTOP in startkde, logged into a session with DesktopNames=TEST --> echo $XDG_CURRENT_DESKTOP says TEST.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdm/backend/client.c <span style="color: grey">(26bb0b4d56ebc87a0e8900b0936a90601a862603)</span></li>
<li>kdm/kfrontend/sessions/gnome.desktop <span style="color: grey">(f4263dd7e75ed90e85ac0002f463c4e594a70f91)</span></li>
<li>kdm/kfrontend/sessions/kde-plasma-safe.desktop.cmake <span style="color: grey">(722091e3693e3fb86bd8983c1e0423a93a2b482d)</span></li>
<li>kdm/kfrontend/sessions/kde-plasma.desktop.cmake <span style="color: grey">(37413b6beea83b33880858502b451eda370cf8f4)</span></li>
<li>kdm/kfrontend/sessions/lxde.desktop <span style="color: grey">(b794fb24e349627df35b82ee4cc722e5fad0090b)</span></li>
<li>kdm/kfrontend/sessions/xfce.desktop <span style="color: grey">(c3362304edea90fd40d19e6c3f4a434ba780b490)</span></li>
<li>kdm/kfrontend/sessions/xfce4.desktop <span style="color: grey">(75c88a13eaf007c0149744c3f437d06532a398b6)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117400/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>