<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117166/">https://git.reviewboard.kde.org/r/117166/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 29th, 2014, 8:39 p.m. UTC, <b>Kirill Elagin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why not simply add a parameter to KApplication constructor?</pre>
</blockquote>
<p>On March 29th, 2014, 8:44 p.m. UTC, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Being?
I'm not aware of such parameter, kdelibs is semi-frozen and the requirement is also pretty special to add such feature to KApplication, yesno?</pre>
</blockquote>
<p>On March 29th, 2014, 8:49 p.m. UTC, <b>Kirill Elagin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've checked KApplication code and it seems that it creates a DBus service unconditionally. Which is pretty weird.
Is that true that _every single_ application wants to be exposed via DBus? I guess, no. I wouldn't call this requirement “special” at all.
I'm not sure about your freezing rules, but adding a parameter with a compatible default value shouldn't be a big deal, right?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">> Is that true that _every single_ application wants to be exposed via DBus?
No idea, but actually cannot think of other cases that don't want to.
I do not expect a freeze exception for this at all, if you think it's reasonable you could propose it for KF5.</pre>
<br />
<p>- Thomas</p>
<br />
<p>On March 29th, 2014, 8:32 p.m. UTC, Thomas Lübking wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kde-workspace, Martin Gräßlin and Kirill Elagin.</div>
<div>By Thomas Lübking.</div>
<p style="color: grey;"><i>Updated March 29, 2014, 8:32 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Turned out it's possible to kquitapp the greeter w/o having to provide the desktop.
whatever is the final resolution to bug #314989 resp. review #117157, ignorantly exposing the /MainApplication object on this process is certainly a bug. (I considered turning it into a QApplication, but that would have turned a HUGE patch and also the KDebug interface might be a benefit)
As the issue exists since 4.10, i don't think it's necessary to press this into 4.11.8 (and break the "workaround" in bug #314989, which then can be reasonably resolved before 4.11.9)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">locked screen, checked dbus interface of the greeter - MainApplication is gone.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksmserver/screenlocker/greeter/greeterapp.cpp <span style="color: grey">(c5e2f85)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117166/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>