<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116522/">https://git.reviewboard.kde.org/r/116522/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 2nd, 2014, 12:07 a.m. UTC, <b>Kai Uwe Broulik</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<br style="display: none;" />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/116522/file/1087/" style="color: black; font-weight: bold; font-size: 9pt;">after-3.png</a>
<p>after-3.png</p>
</td>
</tr>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">There is no way to send an E-Mail anymore?
Mabye use a text link instead for all platforms and get rid of that misused toolbar button altogether.</pre>
</blockquote>
<p>On March 2nd, 2014, 12:48 a.m. UTC, <b>Yue Liu</b> wrote:</p>
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I feel any contact info feature in about dialog is not very useful. If a user want to contact developer for software-related stuff, they should go to a public channel like irc/ml/bugzilla so that information is shared by the whole community. If they want to contact a developer for something in person, since they know the developer in person they should already have good communication channel to that developer.</pre>
</blockquote>
<p>On March 3rd, 2014, 9:10 a.m. UTC, <b>Frank Reininghaus</b> wrote:</p>
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">But then we should remove the possibility to send an E-mail on all platforms, not just MacOS. I would welcome such a change because users do use that link in the "About Dolphin" dialog to send me bug reports and support requests, which should better go to bugs.kde.org and forum.kde.org, respectively.</pre>
</blockquote>
<p>On March 27th, 2014, 3:36 a.m. UTC, <b>Yue Liu</b> wrote:</p>
<blockquote style="margin: 1em 0 0 1em; border-left: 2px solid #d0d0d0; padding: 0 0 0 1em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Anyone interested in this discussion? Should personal contact method provided in about dialog?</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I am not sure if i want the email there or not but I think this discussion should not happen in a review request called "Make KAboutDialog looks better under OSX". If you want to discuss removing emails globally from the about dialog i'd open a new thread in kde-core-devel about it.</pre>
<br />
<p>- Albert</p>
<br />
<p>On March 1st, 2014, 11:06 p.m. UTC, Yue Liu wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs.</div>
<div>By Yue Liu.</div>
<p style="color: grey;"><i>Updated March 1, 2014, 11:06 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Removed close button, because About dialog on OSX usually don't have any buttons.
Don't draw QFrame in title widget because QFrame::styledPanel looks ugly on OSX.
KToolBar also looks ugly so removed main links and social links.
Focus shadow for QListView is also ugly so disabled focus.
Patch should also work for frameworks but it seems files are split to different parts, can anyone tell me where can I find all the files touched in this patch?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works on OSX 10.9.2</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/dialogs/kaboutapplicationdialog.cpp <span style="color: grey">(8c50615)</span></li>
<li>kdeui/dialogs/kaboutapplicationpersonlistdelegate_p.cpp <span style="color: grey">(5b7c278)</span></li>
<li>kdeui/widgets/ktitlewidget.cpp <span style="color: grey">(8464d7e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116522/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/03/01/a7c007c8-08c4-4537-a679-5487ad36d261__before-1.png">before-1.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/03/01/66e2b0ca-8a75-4db1-9433-791c44958c3d__before-2.png">before-2.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/03/01/9c0b2e5f-9fab-4f15-a916-715a60eb60f2__before-3.png">before-3.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/03/01/39880e76-adeb-4d3d-bee3-a9029b4ed060__after-1.png">after-1.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/03/01/f8a4472a-1eb7-4a89-9f13-434676547e63__after-2.png">after-2.png</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/03/01/1b290e0c-97f9-448e-b83e-67144773bdbb__after-3.png">after-3.png</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>