<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117088/">https://git.reviewboard.kde.org/r/117088/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On March 26th, 2014, 2:29 p.m. UTC, <b>Hrvoje Senjan</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">>(dbus docs say the name of a .service file is arbitrary)
it is. however, with this solution, user will never know (i.e. predict) will kuiserver, or kuiserver5 be started - unless you also change the name (not filename) of the service. that will however then need adjusting in 'downstream' consumers of kuiserver</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">But then it won't be compatible between uses in kdelibs4 land and users in kf5 land.
</pre>
<br />
<p>- Jonathan</p>
<br />
<p>On March 26th, 2014, 2:03 p.m. UTC, Jonathan Riddell wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Runtime and Aleix Pol Gonzalez.</div>
<div>By Jonathan Riddell.</div>
<p style="color: grey;"><i>Updated March 26, 2014, 2:03 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-runtime
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Rename kuiserver to kuiserver5 for co-installability with kdelibs4 kde-runtime
(dbus docs say the name of a .service file is arbitrary)
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kuiserver/CMakeLists.txt <span style="color: grey">(a724326)</span></li>
<li>kuiserver/kf5_org.kde.kuiserver.service.in <span style="color: grey">(PRE-CREATION)</span></li>
<li>kuiserver/kuiserver.desktop <span style="color: grey">(2d7a874)</span></li>
<li>kuiserver/org.kde.kuiserver.service.in <span style="color: grey">(a900b64)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117088/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>