<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/108808/">https://git.reviewboard.kde.org/r/108808/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
<tr>
<td>
<h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been discarded.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kdelibs and kwin.</div>
<div>By Martin Gräßlin.</div>
<p style="color: grey;"><i>Updated March 18, 2014, 4:28 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Do not reset opacity if call for GetWindowProperty fails
The opacity got unconditionally reset to the default value of fully
opaque. In case the property has a value of 0 and the call to get the
window property fails, the window would be shown again. This issue was
spotted with colibri which faded out it's window and got a flash to
fully opaque again.
I'm sorry that it's difficult to read this patch properly due to the
existing mixing of tabs and whitespaces. The patch changes two things:
* only updates the value if all checks succeed
* initialise the data_ret variable to not cause a crash on free
BUG: 314427
FIXED-IN: 4.10.1</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/windowmanagement/netwm.cpp <span style="color: grey">(cf28339f90dff1d17ed17842c7c11d8a9718a459)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/108808/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>