<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115964/">https://git.reviewboard.kde.org/r/115964/</a>
     </td>
    </tr>
   </table>
   <br />





<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
 <p style="margin-top: 0;">On February 25th, 2014, 11:03 a.m. UTC, <b>Hugo Pereira Da Costa</b> wrote:</p>
 <blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Right now, I'm not able to compile, due to:

home/hpereira/kf5/src/kde-workspace/kstyles/oxygen/oxygenstyle.cpp: In constructor ‘Oxygen::Style::Style()’:
/home/hpereira/kf5/src/kde-workspace/kstyles/oxygen/oxygenstyle.cpp:193:60: error: ‘class Oxygen::StyleConfigData’ has no member named ‘sharedConfig’
         _helper( new StyleHelper( StyleConfigData::self()->sharedConfig() ) ),

Does this review depend on some pending changes in kconfig ?</pre>
 </blockquote>







</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">right, should have mentionned it, sorry: it depends on https://git.reviewboard.kde.org/r/115960/</pre>
<br />










<p>- David</p>


<br />
<p>On February 23rd, 2014, 12:08 p.m. UTC, David Faure wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
 <tr>
  <td>

<div>Review request for kde-workspace and Hugo Pereira Da Costa.</div>
<div>By David Faure.</div>


<p style="color: grey;"><i>Updated Feb. 23, 2014, 12:08 p.m.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Oxygen: avoid calls to reparseConfiguration() on startup.

strace -e open kate |& grep -v NOENT | grep oxygenrc | wc -l
  went from 8 to 4
  (and when looking for kdeglobals, from 13 to 11)

There's still a lot of work to be done in that area...
(within KConfigSkeleton, and probably kdeplatformtheme)</pre>
  </td>
 </tr>
</table>



<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kstyles/oxygen/oxygenshadowhelper.h <span style="color: grey">(066edd3292f390401691a9d6e5182e9dc6d24133)</span></li>

 <li>kstyles/oxygen/oxygenshadowhelper.cpp <span style="color: grey">(b3f3d0c876067292a72647e9fcda07cbbf4ba4b0)</span></li>

 <li>kstyles/oxygen/oxygenstyle.h <span style="color: grey">(35323b4578eb9aa0d1efcc5901bab80fadea64f3)</span></li>

 <li>kstyles/oxygen/oxygenstyle.cpp <span style="color: grey">(f6ff24ad515003ad031c80665935e6d113b5a1e5)</span></li>

 <li>kstyles/oxygen/oxygenstylehelper.h <span style="color: grey">(57b86c7ed540364040e87a8464299db17c460647)</span></li>

 <li>kstyles/oxygen/oxygenstylehelper.cpp <span style="color: grey">(f2af4172c5beb8b8c3bb0d75b5eb351dc710289e)</span></li>

 <li>kwin/clients/oxygen/demo/oxygenshadowdemodialog.cpp <span style="color: grey">(9e1481cab4cca2961b48c791e72d925ae4a83d05)</span></li>

 <li>kwin/clients/oxygen/oxygendecohelper.h <span style="color: grey">(4c9a44ab54edec7bdc428f33e580efc60efdf235)</span></li>

 <li>kwin/clients/oxygen/oxygendecohelper.cpp <span style="color: grey">(e6bbcbf9df7eee3188c84cd74f0e32b7cfd162d3)</span></li>

 <li>kwin/clients/oxygen/oxygenfactory.h <span style="color: grey">(9ed90ec1567ed537a3524b2d4a507a3471341a64)</span></li>

 <li>kwin/clients/oxygen/oxygenfactory.cpp <span style="color: grey">(6d5b08b9160a7794f668feb2914450b602360ce6)</span></li>

 <li>libs/oxygen/oxygenhelper.h <span style="color: grey">(ee381a74320da172e834550f61ef214377870bfc)</span></li>

 <li>libs/oxygen/oxygenhelper.cpp <span style="color: grey">(cd6562b411fdb1bce6d0c740a4b38dae33218324)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115964/diff/" style="margin-left: 3em;">View Diff</a></p>







  </td>
 </tr>
</table>








  </div>
 </body>
</html>