<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115695/">https://git.reviewboard.kde.org/r/115695/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kde-workspace, KDE Frameworks, Plasma, and Sune Vuorela.</div>
<div>By Martin Klapetek.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
knotifications
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch merges KNotify daemon into KNotificationManager to have less daemons running and less dbus traffic. The patch is not yet finished (and for now it's full of QDebugs, that will all be removed and FIXMEs to indicate what needs doing), but as the Alpha2 is quite soon, I'd like to start the general review asap so some more changes can be done if needed.
Now it's KNotificationManager that handles the KNotifyPlugin-s and hands them the notification directly. KNotifyConfig was repurposed a bit, now it serves mostly just as the .notifyrc wrapper, all the rest is reused from the KNotification object. There are some changes in the KNotification API - id() and appName() are now exposed to public and "slotReceivedId(int)" is now also public so that KNotificationManager can directly give it an id. I'd like to rename this and make it a non-slot. It's not the DBus/Galago server ID anymore, that is handled in NotifyByPopup which is responsible for communicating with the galago server (all the methods there were renamed to actually have *galago* in the name so it's clear), therefore the mapping of DBus/Galago Server ids is ma
naged only there as it is actually only needed here. KNotitification::id() is assigned by the KNotificationManager and it's a simple increasing counter.
The UI/Plasmoid changes will come next - basically the plan is to put only the "Persistent" notifications in the notifications history.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Works perfectly with both plasma notifications and kpassivepopup.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/notifybypopupgrowl.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/notifybypopupgrowl.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/notifybypopup.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/notifybypopup.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/knotifyplugin.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/knotifyplugin.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/knotifyconfig.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/knotifyconfig.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/knotificationmanager.cpp <span style="color: grey">(a4d0dfa)</span></li>
<li>src/knotificationmanager_p.h <span style="color: grey">(81d962d)</span></li>
<li>src/knotification.cpp <span style="color: grey">(5d7405b)</span></li>
<li>src/knotification.h <span style="color: grey">(00554ba)</span></li>
<li>CMakeLists.txt <span style="color: grey">(63ebf71)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(a81b913)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115695/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>