<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115311/">https://git.reviewboard.kde.org/r/115311/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Looks fine (and required) - thanks.
In case you do not have commit rights (nor do intend to ask for), please upload a "git format-patch" variant (to maintain the commit metadata, namely your identity)
For potential future patches (welcome ;-) please set the group to "kwin", the KWin maintainer is "graesslin".</pre>
<br />
<p>- Thomas Lübking</p>
<br />
<p>On January 25th, 2014, 1:57 a.m. UTC, James Jones wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kde-workspace, Thomas Lübking and Marco Martin.</div>
<div>By James Jones.</div>
<p style="color: grey;"><i>Updated Jan. 25, 2014, 1:57 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">[kwin] Don't call into GL without a context
After losing current from the EGL or GLX
context, calls to the GL or GLES functions
have undefined behavior. Perform all
cleanup that may touch OpenGL and check for
GL errors before losing current from the
context.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compiled/Installed kde-workspace on x86
kwin_gles (EGL+X11) - Tested mode switching
kwin (GLX) - Tested mode switching</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kwin/egl_wayland_backend.cpp <span style="color: grey">(b229cdd84161a64d5cd93c189514067867773e7f)</span></li>
<li>kwin/eglonxbackend.cpp <span style="color: grey">(dd41da55b94821802f2d1464794db39bd636088a)</span></li>
<li>kwin/glxbackend.cpp <span style="color: grey">(73f463e9df43c2cd71836ce3f48da84fb4df35ed)</span></li>
<li>kwin/scene_opengl.cpp <span style="color: grey">(961e81fbcc39940bc49179899e034ad8a9e802cd)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115311/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>