<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114567/">https://git.reviewboard.kde.org/r/114567/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/114567/diff/2/?file=227131#file227131line85" style="color: black; font-weight: bold; text-decoration: underline;">ksmserver/screenlocker/ksldapp.h</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">85</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="nf">lock</span><span class="p">(</span><span class="kt">bool</span> <span class="n">immediateLock</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">85</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">void</span> <span class="nf">lock</span><span class="p">(</span><span class="kt"><span class="hl">bool</span></span><span class="hl"> </span><span class="n"><span class="hl">secLock</span></span><span class="p"><span class="hl">,</span></span><span class="hl"> </span><span class="kt">bool</span> <span class="n">immediateLock</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Note that this is a "boolean trap"[1], also the argument for "secondary" should imho be the second argument.
http://ariya.ofilabs.com/2011/08/hall-of-api-shame-boolean-trap.html</pre>
</div>
<br />
<p>- Martin Klapetek</p>
<br />
<p>On January 23rd, 2014, 12:17 a.m. CET, James Smith wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kde-workspace and Aaron J. Seigo.</div>
<div>By James Smith.</div>
<p style="color: grey;"><i>Updated Jan. 23, 2014, 12:17 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Adds a second screen locking keyboard combination to provide advanced selective lock signaling to running applications for such things as pausing MPRIS2 players in Kmix to setting away status in Telepathy. Applications are connected differently from standard screen saver signaling which is decidedly a blunt handled instrument.
A SecondaryActiveChanged signal for freedesktop.org in addition to ActiveChanged would be great to have moved into freedesktop.org with the above goal and cross-desktop in mind. Right now the implementation sits happily in org.kde.screensaver.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compile, run. </pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>ksmserver/screenlocker/ksldapp.h <span style="color: grey">(b292b62)</span></li>
<li>ksmserver/screenlocker/ksldapp.cpp <span style="color: grey">(7c2d63f)</span></li>
<li>ksmserver/screenlocker/interface.cpp <span style="color: grey">(e3579fb)</span></li>
<li>ksmserver/screenlocker/interface.h <span style="color: grey">(97a6073)</span></li>
<li>ksmserver/screenlocker/dbus/org.kde.screensaver.xml <span style="color: grey">(e700b88)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114567/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>