<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114999/">https://git.reviewboard.kde.org/r/114999/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 14th, 2014, 8:22 p.m. CET, <b>Martin Gräßlin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">like with the other patch I'm not sure whether that's a good idea as that breaks any communication with the kdelibs4.</pre>
</blockquote>
<p>On January 14th, 2014, 9:14 p.m. CET, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">is there a functional incompitibility between SC4 and KF5 that requires such disambiguation or is this merely a package installation conflict resolution?</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I did the port of kglobalacceld and had no problem at all. Also running KWin/5 linked against kglobalaccel talking to kglobalacceld/4 was no problem. So from that I *assume* that there are no functional incompatibilities.</pre>
<br />
<p>- Martin</p>
<br />
<p>On January 14th, 2014, 4:21 p.m. CET, Jonathan Riddell wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Runtime, David Faure and Martin Klapetek.</div>
<div>By Jonathan Riddell.</div>
<p style="color: grey;"><i>Updated Jan. 14, 2014, 4:21 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kglobalaccel
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Rename the dbus interfaces from
org.kde.kglobalaccel.Component to org.kde.kf5kglobalaccel.Component
and
org.kde.kglobalaccel to org.kde.kf5kglobalaccel
this prevents files overlapping with equivalents in kdelibs4 and prevents an overlap of the dbus interface
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/CMakeLists.txt <span style="color: grey">(d48e92e)</span></li>
<li>src/kglobalaccel.h <span style="color: grey">(d11881c)</span></li>
<li>src/kglobalaccel.cpp <span style="color: grey">(54d18ec)</span></li>
<li>src/kglobalaccel_p.h <span style="color: grey">(b1528dc)</span></li>
<li>src/kglobalshortcutinfo.h <span style="color: grey">(7f0e18a)</span></li>
<li>src/org.kde.KF5KGlobalAccel.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/org.kde.KGlobalAccel.xml <span style="color: grey">(8746551)</span></li>
<li>src/org.kde.kf5kglobalaccel.Component.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/org.kde.kglobalaccel.Component.xml <span style="color: grey">(ec21201)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114999/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>