<div dir="ltr">Great. I will commit the patch once I get a chance then. Unless of course either you or Albert has already done so.<br></div><div class="gmail_extra"><br><br><div class="gmail_quote">On Wed, Dec 11, 2013 at 3:30 AM, Ben Cooksley <span dir="ltr"><<a href="mailto:bcooksley@kde.org" target="_blank">bcooksley@kde.org</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr"><div><div class="h5">On Wed, Dec 11, 2013 at 2:52 PM, Dawit A <span dir="ltr"><<a href="mailto:adawit@kde.org" target="_blank">adawit@kde.org</a>></span> wrote:<br>
</div></div><div class="gmail_extra"><div class="gmail_quote"><div><div class="h5"><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div dir="ltr"><div>On Tue, Dec 10, 2013 at 1:45 PM, Albert Astals Cid <span dir="ltr"><<a href="mailto:aacid@kde.org" target="_blank">aacid@kde.org</a>></span> wrote:<br></div><div class="gmail_extra"><div class="gmail_quote">
<div>
<blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">El Dimarts, 10 de desembre de 2013, a les 08:57:47, Dawit A va escriure:<br>
<div>> Sorry for the late response. I did not see this email for some reason. None<br>
> of the test cases in testRetryDialog hit that assert on my machine.<br>
<br>
</div>Is your Qt compiled in debug or release? Because as my original e-mail says if<br>
it's in release the assert won't trigger.<br></blockquote><div><br></div></div><div>Ahh... I assumed you were talking about kde-runtime not Qt.</div><div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div><br>
> If this<br>
> unit test fails on your system, can you please enable the debug area for<br>
> KPasswdServer, run the unit test only for testRetryDialog only and provide<br>
> the output from it?<br>
<br>
</div>Attached, is that enough?<br></blockquote><div><br></div></div><div>That is fine. The test is indeed doing the wrong thing. It conflated two cases that should be tested separately into one. </div><div><blockquote class="gmail_quote" style="margin:0px 0px 0px 0.8ex;border-left-width:1px;border-left-color:rgb(204,204,204);border-left-style:solid;padding-left:1ex">
<div><br>
> I am curious to know why it would start failing all of<br>
> the sudden since nothing was changed in that code base in a very long time.<br>
<br>
</div>Because we switched to a debug Qt that now has asserts enabled.<br></blockquote><div><br></div></div><div>Right.</div><div><br></div><div>Can you please check if the attached pass works fine for you? It fixes the broken test case for me here.</div>
</div></div></div></blockquote><div><br></div></div></div><div>I have now tested that patch on the CI system. It fixes the issue Albert mentions.</div><div><br></div><div>Test project /srv/jenkins/workspace/kde-runtime_master/build</div>
<div> Start 1: kpasswdservertest</div><div>1/9 Test #1: kpasswdservertest ................ Passed 0.28 sec</div><div> Start 2: testkioarchive</div><div>2/9 Test #2: testkioarchive ................... Passed 0.29 sec</div>
<div> Start 3: testtrash</div><div>3/9 Test #3: testtrash ........................ Passed 1.72 sec</div><div> Start 4: testdesktop</div><div>4/9 Test #4: testdesktop ...................... Passed 0.31 sec</div>
<div> Start 5: kurifiltertest</div><div>5/9 Test #5: kurifiltertest ................... Passed 10.07 sec</div><div> Start 6: backtraceparsertest</div><div>6/9 Test #6: backtraceparsertest .............. Passed 5.67 sec</div>
<div> Start 7: filetypestest</div><div>7/9 Test #7: filetypestest .................... Passed 1.18 sec</div><div> Start 8: sortfiltermodeltest</div><div>8/9 Test #8: sortfiltermodeltest .............. Passed 0.04 sec</div>
<div> Start 9: fullmodelaccesstest</div><div>9/9 Test #9: fullmodelaccesstest .............. Passed 0.01 sec</div><div><br></div><div>100% tests passed, 0 tests failed out of 9</div><div><br></div><div>
Regards,</div><div>Ben</div></div></div></div>
</blockquote></div><br></div>